page_parser file naming

Bug #896572 reported by Olivier Doucet
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Data Recovery Tool for InnoDB
New
Wishlist
Unassigned

Bug Description

Tool page_parser has a curious way to name page files. As stated in documentation (http://www.percona.com/docs/wiki/innodb-data-recovery-tool:mysql-data-recovery:extracting_the_desired_pages) :
pages-1301110359/0-52/
pages-1301110359/0-52/216-00000216.page
pages-1301110359/0-52/70-00000216.page
"The file 70-00000216.page was read before the file 216-00000216.page; this physical ordering can be important to preserve."

I wondered why page files are not named like this :
pages-1301110359/0-52/00216-00000216.page
pages-1301110359/0-52/00070-00000216.page

It is easier to order this way and modification is very easy : just change sprintf format to use "%08lu" instead of "%lu"

    175 if(is_index){
    176 sprintf(file_name, "%s/%08lu-%08lu.page", dir_name, id++, page_id);
    177 }

If there is an other cause of this naming, sorry for the disturbance.

Changed in percona-data-recovery-tool-for-innodb:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.