make_app() does not instantiate DebugMiddleware() with conf.app.debugger

Bug #1449573 reported by Joe D'Andrea
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pecan
Fix Released
Undecided
Joe D'Andrea

Bug Description

DebugMiddleware supports an optional debugger param, but make_app does not take advantage of it. pdb.post_mortem is always used.

Joe D'Andrea (jdandrea)
Changed in pecan:
assignee: nobody → Joe D'Andrea (joedandrea)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pecan (master)

Fix proposed to branch: master
Review: https://review.openstack.org/178249

Changed in pecan:
status: New → In Progress
Joe D'Andrea (jdandrea)
summary: - make_app does not instantiate DebugMiddleware() with app.debugger
+ make_app() does not instantiate DebugMiddleware() with app.debugger
summary: - make_app() does not instantiate DebugMiddleware() with app.debugger
+ make_app() does not instantiate DebugMiddleware() with conf.app.debugger
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pecan (master)

Reviewed: https://review.openstack.org/178249
Committed: https://git.openstack.org/cgit/stackforge/pecan/commit/?id=ec7bdc432dd8be86a4d9e9d20cf35013ca295e86
Submitter: Jenkins
Branch: master

commit ec7bdc432dd8be86a4d9e9d20cf35013ca295e86
Author: Joe D'Andrea <email address hidden>
Date: Tue Apr 28 11:33:49 2015 -0400

    make_app() now uses the debugger param in DebugMiddleware()

    Setting app.debugger in setup.py now takes proper effect.
    A warning is issued if the entry point is not callable.

    Change-Id: I58a860b8ef0e1cb956b4554071275c024a1949d2
    Closes-Bug: #1449573

Changed in pecan:
status: In Progress → Fix Committed
Changed in pecan:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.