PCB: Printed Circuit Board CAD package

ImportGUI() says "Load Schematics" but cannot do multiple selections

Reported by Dan White on 2012-02-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Undecided
Unassigned

Bug Description

The PCB file format and Import() action support multiple schematic files, but ImportGUI() only handles single files

It is a common (for me at least) use case to have a board design live in multiple schematics. Giving ImportGUI() the ability to select multiple files and record appropriate "import::srcN" attributes would be nice.

The attached patch does just this. It adds as a side effect a new "ghid_dialog_file_select_multiple()" function to make it happen. It does not setup the dialog with schematic filetype filters.

The patch also lives on my pcb fork at repo.or.cz as (currently) commit e41cbedf4e2bc34f556545c180a006c8e7dc9e34

http://repo.or.cz/r/geda-pcb/whiteaudio.git

Dan White (etihwnad) wrote :

now commit # e53244102ff0dfe4c389b81f7497347a51c8134e

Felix Ruoff (felixruoff) wrote :

Thanks for this Patch! Very helpfull for me.
I have replaced g_object_set (dialog, "select-multiple", TRUE); by gtk_file_chooser_set_select_multiple(dialog, TRUE); because it throws a warning at my system.

Changed in pcb:
status: New → Fix Committed
Changed in pcb:
status: Fix Committed → Fix Released
Changed in pcb:
milestone: none → pcb-20140316
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers