pcb

lib/pcblib-newlib is in TOPSRCDIR not in TOP_BUILDDIR

Bug #855405 reported by أحمد المحمودي (Ahmed El-Mahmoudy) on 2011-09-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	pcb	Fix Released	Medium	Unassigned	pcb pcb-20140316

Bug Description

src/pcbtest.sh.in tries to find lib/pcblib-newlib in TOP_BUILDDIR instead of TOPSRCDIR, which causes the following error when running 'make check' in the case of out of source building:
../../../src/pcbtest.sh -x gcode --dpi 1200 ../../tests/inputs/gcode_oneline.pcb
Can't change working directory to
'/tmp/pcb-20110918/build_lesstif/lib/pcblib-newlib'
chdir() returned: 'No such file or directory'

The attached patch fixes this.

Tags:

Revision history for this message

أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) wrote on 2011-09-21:

pcbtest_paths.diff Edit (798 bytes, text/plain)

أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy) on 2011-09-21

tags:

added: patch

Peter Clifton (pcjc2) on 2011-09-21

Changed in pcb:
importance:	Undecided → Medium
milestone:	none → next-bug-release
milestone:	next-bug-release → future-bug-release

Revision history for this message

DJ Delorie (djdelorie) wrote on 2011-11-19:

I just did a build in a separate build tree, and lib/pcblib-newlib is in the build tree, not the source tree.

Revision history for this message

Vladimir Zhbanov (vzhbanov) wrote on 2014-01-31:

The command to check the bug exists:
LANG=C make distcheck |grep -B10 "No such file or directory"

Changed in pcb:
status:	New → Confirmed

Vladimir Zhbanov (vzhbanov) on 2014-01-31

Changed in pcb:
status:	Confirmed → Fix Committed

Bert Timmerman (bert-timmerman) on 2014-03-18

Changed in pcb:
status:	Fix Committed → Fix Released

Bert Timmerman (bert-timmerman) on 2014-03-19

Changed in pcb:
milestone:	next-bug-release → pcb-20140316

Revision history for this message

gpleda.org commit robot (gpleda-launchpad-robot) wrote on 2014-03-29:

Bug was fixed by a commit
git master commit cfd09c2f34d8fcbd04f625ab45b2755dd3bfd29d
http://git.geda-project.org/pcb/commit/?id=cfd09c2f34d8fcbd04f625ab45b2755dd3bfd29d

commit cfd09c2f34d8fcbd04f625ab45b2755dd3bfd29d
Author: أحمد المحمودي (Ahmed El-Mahmoudy) <email address hidden>
Commit: Vladimir Zhbanov <email address hidden>

Fix 'make distcheck'

Use proper target directory for pcblib-newlib.

Closes-bug: lp-855405

Commit-message-by: Vladimir Zhbanov <email address hidden>