No diamond in current git head

[KaiMartin]

Current git head fails to show the diamond that marks the origin of a footprint.

To reproduce:

1) open pcb (downloaded from git on august 23.)
2) insert SO8.fp from the pclib/~geda lib
There is no diamond shown in the center of the footprint.

---<)kaimartin(>---

[DJ Delorie (djdelorie)]

I noted earlier that the diamond is there, but very tiny - the units scaling is off. Zoom *way* in and you can see it.

[KaiMartin (kmk-familieknaak)]

The diamond also does not show up in the sketch when the footprint is in the buffer.

In addition, the mouse does not snap where the diamond is supposed to be.

--<)kaimartin(>---

[KaiMartin (kmk-familieknaak)]

Ok, I can spot a tiny diamond in the middle of a screen filling 0603 resistor :-)
Still, it is a disabling regression. It prevents me from reliably put footprints where I want.

By the way, this also shows, that the snapping mechanism definitely needs some more love. I did not reckognize the mouse snap to to the invisibly diamond, even though it probably did.

---<)kaiamrtin(>---

[Andrew Poelstra (asp11)]

Confirmed. Undoubtedly the result of my unit conversion.

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit ac0c3a203fc29adbf4e9e01faa86bd7b8ff2ea51
http://git.gpleda.org/?p=pcb.git;a=commit;h=ac0c3a203fc29adbf4e9e01faa86bd7b8ff2ea51

commit ac0c3a203fc29adbf4e9e01faa86bd7b8ff2ea51
Author: Andrew Poelstra <email address hidden>
Commit: Andrew Poelstra <email address hidden>

    Make EMARK_SIZE unit-agnostic

    Closes-bug: lp-832455