Bug reports should be auto-closed by relevant commits

[Peter Clifton]

We should use a commit hook on gpleda.org to append status changes and / or comments to bugs when commits are made which refer to a particular launchpad bug. This should make it easier for developers to keep the bug tracker in sync with code changes.

[gpleda.org commit robot (gpleda-launchpad-robot)]

That sounds like a good idea to me

[Peter TB Brett (peter-b)]

On Saturday 08 January 2011 18:43:15 Peter Clifton wrote:
> We should use a commit hook on gpleda.org to append status changes and /
> or comments to bugs when commits are made which refer to a particular
> launchpad bug.

I think this is an excellent idea! I suggest the following specification for
what will be picked up by the hook:

  ^[:space:]*Closes-bug:[:space:]+(lp|sf)-[0-9]+[:space:]*$

Should add the commit details (I suggest 'git log' output) as a comment to the
specified bug, and mark the bug as "Fix Committed".

  ^[:space:]*Affects-bug:[:space:]+(lp|sf)-[0-9]+[:space:]*$

Should add the commit details as a comment to the specified bug.

And of course it should be possible to have multiple "Closes-bug" or "Affects-
bug" lines in a given commit message. ;-)

I hope we can get this working soon!

[gpleda.org commit robot (gpleda-launchpad-robot)]

Tell you what.. I'll volunteer to keep an eye on the commits being made. I can login to Launchpad when I see any relevant commits and update the bug statuses. Does that sound helpful?

[Peter Clifton (pcjc2)]

Thankyou gpleda.org commit robot, that sounds like a good plan.

Good luck!

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit eaaded1ec38b6f17099fe62b0f507d8ac05a160c
http://git.gpleda.org/?p=gaf.git;a=commit;h=eaaded1ec38b6f17099fe62b0f507d8ac05a160c

commit eaaded1ec38b6f17099fe62b0f507d8ac05a160c
Author: Peter Clifton <email address hidden>
Commit: Peter Clifton <email address hidden>

    Commit hook test

    This commit is deliberately blank, but should close bug lp-700413 due to
    the line below.

    Closes-bug: lp-700413

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit 10c6f49b1e4d5f49df0772894877ff300ac080ca
http://git.gpleda.org/?p=pcb.git;a=commit;h=10c6f49b1e4d5f49df0772894877ff300ac080ca

commit 10c6f49b1e4d5f49df0772894877ff300ac080ca
Author: Peter Clifton <email address hidden>
Commit: Peter Clifton <email address hidden>

    Commit hook test

    This commit is deliberately blank, but should close bug lp-700413 due to
    the line below.

    Closes-bug: lp-700413

[gpleda.org commit robot (gpleda-launchpad-robot)]

A commit was made which affects this bug
git master commit 7d707745cef867c7386eedba80a113a70ed8823d
http://git.gpleda.org/?p=gaf.git;a=commit;h=7d707745cef867c7386eedba80a113a70ed8823d

commit 7d707745cef867c7386eedba80a113a70ed8823d
Author: Peter Clifton <email address hidden>
Commit: Peter Clifton <email address hidden>

    Test commit: Test commit email and commit hook

    Affects-bug: lp-700413

[gpleda.org commit robot (gpleda-launchpad-robot)]

A commit was made which affects this bug
git master commit 7e8f6fdb2af40cab8e4fe969b25c6aa39f20240d
http://git.geda-project.org/geda-gaf/commit/?id=7e8f6fdb2af40cab8e4fe969b25c6aa39f20240d

commit 7e8f6fdb2af40cab8e4fe969b25c6aa39f20240d
Author: Krzysztof Kościuszkiewicz <email address hidden>
Commit: Krzysztof Kościuszkiewicz <email address hidden>

    commit robot test on geda-project.org

    This commit is deliberately blank (similar to eaaded1ec38). The sole
    purpose is to test the operation of commit robot on the new server.

    Affects-bug: lp-700413

[Felix Ruoff (felixruoff)]

I am sorry to tell, that there seems to be an error with the commit robot while pushing patches to the pcb repository.
The error message is:

... $ git push
Counting objects: 13, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 1.32 KiB, done.
Total 8 (delta 6), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote: File "/geda/commit_robot/commit_robot_post-receive.py", line 471, in <module>
remote: sys.exit(main())
remote: File "/geda/commit_robot/commit_robot_post-receive.py", line 350, in main
remote: db = robot_db(robot_db_file)
remote: File "/geda/commit_robot/commit_robot_post-receive.py", line 126, in __init__
remote: self._dbcon = sqlite3.connect(self._dbfile, timeout=0, isolation_level=None)
remote: sqlite3.OperationalError: unable to open database file
To ssh://<email address hidden>/pcb.git
   8e1d7ce..a044f40 master -> master

Kind regards,
Felix