solder mask drawing glitch in pcb

[rdrehmel]

The attached patch fixes drawing of solder mask above pads.

In the case of having a pad with a solder mask value of 0
(i.e. completely covered by solder mask), the drawing code which
clears the solder mask from the pad should not be run. This
not only saves a few cycles (probably irrelevant), but more importantly
fixes the one-pixel lines of removed solder-mask, which can occur
when Pad->Mask is 0.

[DJ Delorie (djdelorie)]

I think it would be better to not call ClearPad() at all if pad->Mask is 0. The "true" parameter selects the mask or copper clearance size, not whether or not it draws.

[Colin D Bennett (colinb)]

OK, I tested the following updated patch and it fixes the problem of drawing pads which are entirely covered by solder mask:

--- src/draw.c 2010-09-10 14:30:23 +0000
+++ src/draw.c 2010-11-10 23:32:09 +0000
@@ -673,7 +673,12 @@
 {
   PadTypePtr pad = (PadTypePtr) b;
   if (!XOR (TEST_FLAG (ONSOLDERFLAG, pad), SWAP_IDENT))
- ClearPad (pad, true);
+ {
+ if (pad->Mask != 0)
+ {
+ ClearPad (pad, true);
+ }
+ }
   return 1;
 }

[rdrehmel (rdrehmel)]

I added a new patch file which incorporates DJ's suggestion.

[Peter Clifton (pcjc2)]

Committed, thanks!