selectlayer() layer names

[spaceman81]

This function and action selectlayer() took layer numbers, now it also takes layer names. This function is duplicated in lesstif and gtk.

[Ineiev (ineiev)]

Hmm, the gtk part looks like something different. probably you mixed some sources.

Best regards,
   Ineiev

[spaceman81 (spaceman81)]

Youre right. User error in my operation of git diff. Fixed now.

[Jared Casper (jaredcasper)]

Why are you looping through groups, then layers in the group, instead of just looping through layers (i.e. use LAYER_LOOP, not your own for loop then a GROUP_LOOP).

Also, it appears that the nested for loop (the one using i) is the same thing as the GROUP_LOOP, so you are unnecessarily looping over every layer twice.

[gpleda.org commit robot (gpleda-launchpad-robot)]

Bug was fixed by a commit
git master commit 82a0b79c38421a08f334e42f4cdcd252d5f6900d
http://git.geda-project.org/pcb/commit/?id=82a0b79c38421a08f334e42f4cdcd252d5f6900d

commit 82a0b79c38421a08f334e42f4cdcd252d5f6900d
Author: Andrew Poelstra (local) <email address hidden>
Commit: Andrew Poelstra (local) <email address hidden>

    Make SelectLayer() respond to layer name as well as index

    Closes-bug: lp-699470