pcb

More detailed thinlines

Bug #699468 reported by Ineiev on 2009-07-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA project
Wishlist
Unassigned
pcb
Low
Unassigned

Bug Description

Add Display(TogglePedanticThinLines) subaction and PedanticThinLines flag; when the flag is set, thinline mode shows lines and arcs as outlines rather than as center-lines. it is more convenient when looking for spurious line segments.

Ineiev (ineiev) wrote :

Revised patch. added usability handles (menu items, pedantic_thindraw flag, Display(Thindraw) subaction)

Jared Casper (jaredcasper) wrote :

Patch no longer applies because of the ChangeLog, and the first line of action.c. (Is the ChangeLog still helpful/necessary when it is just a copy of random entries from the git log, which is appears to be?)

There's a whitespace issue here:

+ if (argc > 2 && argv[2][0])$
+ { $

Also, the copyright at the top of action.c seems to have moved to using Harry Eaton after 1997, but this patch adds 2009 to the line with Thomas Nau. Not sure if it matters.

Ineiev (ineiev) wrote :

Thank you. I keep rebasing the patch at repo.or.cz
(http://repo.or.cz/w/geda-pcb/dti.git/shortlog/refs/heads/ineiev-outlined.thinlines);
if I recollect correctly, the whitespace issue has been addressed there.

On the ChangeLog, my motive was formal requirement in the GPL to describe the changes.
probably I was wrong; the file is seems to be autoregenerated from git. I think I'll remove ChangeLog entries
from my patches eventually.

On the copyright, I actually don't think it is essential. I "assigned" copyright on my changes
to the original developer just because I didn't want to increase PCB copyright holders number.

Traumflug (mah-jump-ing) on 2015-09-27
Changed in geda-project:
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers