pcb

one-shot warning for failed Display(Pinout)

Bug #699419 reported by Ben Jackson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Won't Fix
Medium
Unassigned

Bug Description

If Display(Pinout) fails because you didn't point to anything, there is absolutely no feedback. This adds a one-time-per-run message warning you that you should move your crosshair to a point.

Tags: sf-patches
Revision history for this message
Ben Jackson (ben.jackson) wrote :
Revision history for this message
Ben Jackson (ben.jackson) wrote :

I haven't applied this because I think the same bug (action requires crosshair to be over something in particular and fails silently) exists many places and should be fixed more completely.

Revision history for this message
Traumflug (mah-jump-ing) wrote :

Thank you for the patch, Ben.

Well, it looks like it's outdated, like it doesn't matter where the crosshair is while typing :display.

It's true that actions should either act or, if they can't, display the help message. I just implemented this for ActionDisplay().

In general I think it's not a good idea to rely on a specific cursor position while there's action on the command line (in another window ! ). Can't remember any other application requiring this.

Marking as "Fix committed", as this particular problem is solved. Further patches are welcome, of course, please open another bug for them. Or even better: commit them directly.

Changed in pcb:
importance: Undecided → Medium
status: New → Fix Committed
Traumflug (mah-jump-ing)
Changed in geda-project:
importance: Undecided → Medium
status: New → Fix Released
Revision history for this message
Chad Parker (parker-charles) wrote :

Patch no longer applies.

Changed in pcb:
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.