size increment preferences not working

[duncan_drennan]

When working with line, hole and copper annulus sizes the increments under "Preferences" do not appear to have any influence. With mm grid the size change is always 0.125mm, and with mil it is always 5 mils (roughly the same). The clearance size always increments/decrements by 0.05mm (2 mils).

This is with pcb version 20080202. I attempted this with different values working with both mil and mm grid.

[alexwarrior (alexwarrior)]

I have this problem with the latest source from git as well. To get around it, I've changed a line in share/pcb/gpcb-menu.res. The following are the lines I changed. Notice the +1 and -1, they were +5 and -5 be default.

    {"ChangeSize +5 mil" a={"S" "<Key>s"} ChangeSize(Object,+1,mil)}
    {"ChangeSize -5 mil" a={"Shift-S" "Shift<Key>s"} ChangeSize(Object,-1,mil)}
    {"ChangeDrill +5 mil" a={"Alt-S" "Alt<Key>s"} ChangeDrillSize(Object,+1,mil)}
    {"ChangeDrill -5 mil" a={"Alt-Shift-S" "Alt Shift<Key>s"} ChangeDrillSize(Object,-1,mil)}

[Ineiev (ineiev)]

I wonder where these +-1 mil could come from. I tried to find them in sources and couldn't (in all revisions of src/gpcb-menu.res I see +-5). can those gpcb-menu.res files belong to some old/non-mainstream distribution?

[nobody (nobody-users)]

Indeed, +-5 are what I see too. That's the problem, the increments are hard-coded at +/-5, and the increment settings in the preferences dialog are ignored. I've posted a patch (ID 2780125) which makes the preferences dialog's increment settings work again by changing the relevant actions to allow a +pref/-pref argument that will apply an increment/decrement. Then, in the (g)pcb-menu.res the new arguments are used by the key/menu shortcuts so that the increments/decrement parameters are used.