pcb

Blind/Buried vias - new feature

Bug #1656661 reported by Milan Prochac
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Wishlist
Bert Timmerman

Bug Description

New implementation of blind/buried vias (from July 2016)

For more details - see user manual (pcb.pdf)

Implemented features:
  - adjusted file format to implement blind/buried vias
  - implemented actions to set first/last layer of the via and convert them to TH vias
  - added menu items and hotkeys bound to these actions
  - extended select actions to cover via type
  - connectivity tests adjusted to correctly resolve blind/buried vias
  - PS and Gerber exports supports blind/buried vias (remaining export filters are not affected by new via types)
  - documentation adjusted
  - new tests and golden images provided

Misssing:
  - special file naming options in gerber exports

Suggested future enhancements
  - definition of allowed layer pairs for blind buried vias and their verification as part of DRC

This implementation is independent of another implementation found here (from 2008); I was not aware of it.

Milan

Revision history for this message
Milan Prochac (milan-x) wrote :
Revision history for this message
Milan Prochac (milan-x) wrote :

Some more features I forgot to mention:
- blind/buried vias can be automatically created when line drawing moves from one layer to another
- blind/buried vias can be created when line segment is moved to another layer - it affects only newly created vias
- both features are controlled by option

Missing:
 - when line segment is moved to another layer, blind/buried vias are not adjusted - feedback from designers using blind/buried vias is necessary as there is several options how to handle it.

Changed in pcb:
status: New → Triaged
Changed in pcb:
importance: Undecided → Wishlist
Changed in pcb:
milestone: none → pcb-4.0.1
Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Milan,

I included the inputs and golden files into the EXTRA_DIST, applied commit to the rebased topic branch LP1656661 and pushed to master.

While testing I found:

Test: hid_gerber4
(cd outputs/hid_gerber4 && ../../../src/pcbtest.sh -x gerber --fab-author Fab_Author --gerberfile buried buried.pcb)

** (process:31437): CRITICAL **: Tool 32 used without being defined

** (process:31437): WARNING **: Setting a default size of 0.272"

FAILED: See outputs/hid_gerber4/mismatch

** (process:31460): CRITICAL **: Tool 33 used without being defined

** (process:31460): WARNING **: Setting a default size of 0.28"

FAILED: See outputs/hid_gerber4/mismatch
FAIL

Output attached as a tarball.

Kind regards,

Bert Timmerman.

Changed in pcb:
status: Triaged → In Progress
assignee: nobody → Bert Timmerman (bert-timmerman)
Revision history for this message
Milan Prochac (milan-x) wrote : Re: [Bug 1656661] Re: Blind/Buried vias - new feature

Hmm, strange. I pulled fresh copy from git, checked out LP1656661,
built it and ran tests from pcb/tests directory:

./run_tests.sh

Result:
----------------------------------------------------------------------
Test: hid_gerber4
(cd outputs/hid_gerber4 && ../../../src/pcbtest.sh -x gerber
--fab-author Fab_Author --gerberfile buried buried.pcb)
PASSED
----------------------------------------------------------------------

How do you run tests? Maybe e run it differently (and my way is wrong)

Milan

On 16.02.2017 22:30, Bert Timmerman wrote:
> Hi Milan,
>
> I included the inputs and golden files into the EXTRA_DIST, applied
> commit to the rebased topic branch LP1656661 and pushed to master.
>
> While testing I found:
>
> Test: hid_gerber4
> (cd outputs/hid_gerber4 && ../../../src/pcbtest.sh -x gerber --fab-author Fab_Author --gerberfile buried buried.pcb)
>
> ** (process:31437): CRITICAL **: Tool 32 used without being defined
>
>
> ** (process:31437): WARNING **: Setting a default size of 0.272"
>
> FAILED: See outputs/hid_gerber4/mismatch
>
> ** (process:31460): CRITICAL **: Tool 33 used without being defined
>
>
> ** (process:31460): WARNING **: Setting a default size of 0.28"
>
> FAILED: See outputs/hid_gerber4/mismatch
> FAIL
>
> Output attached as a tarball.
>
> Kind regards,
>
> Bert Timmerman.
>
> ** Attachment added: "gerber4 test output tarball"
> https://bugs.launchpad.net/pcb/+bug/1656661/+attachment/4820424/+files/hid_gerber4.tar.gz
>
> ** Changed in: pcb
> Status: Triaged => In Progress
>
> ** Changed in: pcb
> Assignee: (unassigned) => Bert Timmerman (bert-timmerman)
>

Revision history for this message
Milan Prochac (milan-x) wrote :

OK, I see now that there are tool definition missing in extra drill layers.. I will check and fix gerber export.

Milan

Revision history for this message
Milan Prochac (milan-x) wrote :

Well, the errors are reported on Excellon drill files, but the tool definition is there. Ignore my previous comment, I was looking for aperture definitions.

I see tool definitions in files

T33C0.020

or

T32C0.035

With gerbv 2.6A they are working correctly.

Q:
- which version of gerbv are you using?
- is the error reported only for hid_gerber4 test or also for other gerber tests?
- do you use any specific configuration for gerbv?

The drill files looks similar as test results from unpatched mainline, IMO no bug was implemented.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Milan,

I did create a test file in the GTK GUI.

Loaded the test file in the Lesstif GUI and created gerber files.

AFAICT, works OK.

Now only to add some functionality in the Lesstif GUI to make our Lesstif users (DJ) happy.

Will add your commits to master.

Kind regards,

Bert Timmerman.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Milan,

Regarding gerbv:

I'm running 2.3.0.

AFAIK, no specific configuration.

Kind regards,

Bert Timmerman.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi all,

I will have to bump the pcb file version to 20170218.

Kind regards,

Bert Timmerman.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Pushed to master.

I will open a new bug report for the Lesstif GUI implementation.

Kind regards,

Bert Timmerman.

Changed in pcb:
status: In Progress → Fix Committed
milestone: pcb-4.0.1 → pcb-4.1.0
Changed in pcb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.