pcb

strchrnull not in OSX C library

Bug #1542858 reported by Chad Parker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Fix Released
Medium
Bert Timmerman

Bug Description

src/hid/gtk/gui-library-window.c references the function strchrnul which is a GNU specific function and not present on OSX.

I tried building with both xcode and with the gcc from macports, and neither was able to find this function in the standard libraries.

I was able to compile pcb by pulling the following files:

http://src.gnu-darwin.org/src/contrib/cpio/lib/strchrnul.c
http://src.gnu-darwin.org/src/contrib/cpio/lib/strchrnul.h

adding it to the makefile.am and putting an include at the top of gui-library-window.c

I'm not sure if this solution works with all licensing issues. I think there's also a tool called gnulib that could be used to pull it in.

Revision history for this message
Chad Parker (parker-charles) wrote :

This occurred building from git on Feb 5th, 2016

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

Hi Chad,

I just cherry-picked and pushed both commits from "home/cparker/LP1542858" to "master".

Can I close this bug report as "Fix Committed" ?

Kind regards,

Bert Timmerman.

Changed in pcb:
importance: Undecided → Medium
assignee: nobody → Bert Timmerman (bert-timmerman)
status: New → In Progress
milestone: none → next-bug-release
Revision history for this message
Chad Parker (parker-charles) wrote :

Please do. Thanks, --Chad

Changed in pcb:
status: In Progress → Fix Committed
Changed in pcb:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.