pcb

Cannot create a via with a copper annulus less than 0.0508mm

Bug #1539882 reported by Rob Spanton on 2016-01-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
Low
Rob Spanton

Bug Description

Currently, pcb requires that vias and pins have a copper annulus of 0.0508mm, and if they don't, pcb will increase the pad size to enforce this requirement.

This should really be something that is enforced by a DRC, rather than a hard-coded constant.

Find a patch attached that fixes this issue.

Peter Clifton (pcjc2) wrote :

Deemed to be a valid feature request / bug.

I believe the code to impose the minimums for older file format loads is unnecessary, so should be removed - rather than patched to retain the old minimum.

Changed in pcb:
status: New → Triaged
Changed in pcb:
milestone: none → next-bug-release
importance: Undecided → Low
Rob Spanton (r-rnb-2) wrote :

Ok, I've removed the old file format support stuff. There was also an issue with an extra use of MIN_PINORVIACOPPER that the first patch didn't remove (I actually wrote this patch about a year ago, and I assume it crept in since then), which I've also removed. Patch attached.

Tested with round, square and octagonal pin pads.

Changed in pcb:
milestone: next-bug-release → future-bug-release
Changed in pcb:
milestone: pcb-4.1.1 → pcb-4.2.0
Changed in pcb:
milestone: pcb-4.2.0 → future-bug-fix-release
Changed in pcb:
milestone: future-bug-fix-release → pcb-4.2.0
Chad Parker (parker-charles) wrote :

The attached patches are slightly bit-rotted, however, not so much so that they couldn't be easily salvaged.

I've applied the patches and put the result in branch: LP1539882

I've confirmed that, for at least a circular via, master currently does add the extra, and after the patch is applied, it no longer does.

Unless there are any objections, I'm going to pull this into master for the upcoming release.

Changed in pcb:
assignee: nobody → Chad Parker (parker-charles)
status: Triaged → In Progress
Chad Parker (parker-charles) wrote :

Rob- I've "assigned" you to this bug so that you can get some credit for submitting the patch that fixed it. No further action is needed on your part.

Thanks for you patch.
--Chad

Changed in pcb:
status: In Progress → Fix Committed
assignee: Chad Parker (parker-charles) → Rob Spanton (r-rnb-2)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints