default silk layer names are the same for top and bottom

[KaiMartin]

The default layer stack as set by PCB for a new layout contains two silk layers. Both of them bear the same name "silk". The name does not actually show in the GUI. Still, it is irritating when editing the pcb file manually. In addition, the duplicate name complicates scripted manipulation of the file.

The attached patch sets the default name to "top silk" and "bottom silk" respectively.
---<)kaimartin(>---

[Bert Timmerman (bert-timmerman)]

HI Kai-Martin,

The patch seems to work as expected.

Kind regards,

Bert Timmerman.

[Bert Timmerman (bert-timmerman)]

Hi Kai-Martin and all,

I have pushed a topic branch "LP1035979" onto git://git.geda-project.org/pcb with the above mentioned patch.

Please "git fetch", "git checkout -b LP1035979" and test this patch for unwanted side effects.

Kind regards,

Bert Timmerman.

[KaiMartin (kmk-familieknaak)]

With the above patch, the GUI does not properly change the name of the silk layer, if the view switches from top view to bottom view (ctrl+shift+tab). Instead, it reverts to the string "silk" which is hard coded in src/hid/gtk/gui-top-window.c . The attached patch fixes this issue.

---<)kaimartin(>---

[KaiMartin (kmk-familieknaak)]

Just a clarification: Both pathes are required to make the silk layers apear as "top silk" and "bottom silk".

---<)kaimartin(>---

[Bert Timmerman (bert-timmerman)]

Hi Kai-Martin and all,

I have updated the topic branch "LP1035979" onto git://git.geda-project.org/pcb with the above mentioned patches.

Seems to work as advertised.

Kind regards,

Bert Timmerman.

[Bert Timmerman (bert-timmerman)]

Subject: Re: [geda-user] Accessing bottom silk
From: Kai-Martin Knaak <email address hidden>
Date: Thu, 31 Jan 2013 02:51:38 +0100
To: <email address hidden>

Bert Timmerman <email address hidden> schrieb am 29. January 2013:

> > Your patches live in a topic branch in the upstream pcb repo.
> > See here: http://git.geda-project.org/pcb/log/?h=LP1035979
> > I will test these more thorough when I have some free cycles.

I found a glitch:
With my patches applied, stand-alone objects on silk cannot be deleted.
Seems like the delete action depends on the hard coded string "silk". I
will investigate and add to the patch.

---<)kaimartin(>---
-- Kai-Martin Knaak

[Bert Timmerman (bert-timmerman)]

Hi Kai-Martin,

I can not reproduce the "glitch" whilst deleting stand-alone objects on silk (started a new layout and draw some stuff on all layers) while testing your patches.

Could you please confirm these "glitches" still occur on the current HEAD of pcb.git.

I want to commit these patches to the "master" branch as I find this functionality useful for pcb.

TIA and with kind regards,

Bert Timmerman.

[Traumflug (mah-jump-ing)]

OK, apparently one can't change status and add a comment with one send. :-) Let me repeat:

Regarding the first patch, an identical one was authored and comitted to master by Peter Clifton on Jan 11, 2015.

Regarding the other patch, rebasing to master required a few adjustments due to variable name changes. It works fine and is IMHO an improvement. So I picked it onto master.

If the glitch ever re-appears, please open a new bug. Thanks for the contribution, KaiMartin.

[KaiMartin (kmk-familieknaak)]

Just checked myself:
The glitch I saw does not happen with current git head.

Thank you Traumflug for applying my patch.