OS X 10.8.4 "make" command generates warnings
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pbzip2 |
Fix Released
|
Low
|
Yavor Nikolov |
Bug Description
Doing a make in OS X 10.8.4 generates some warnings that look potentially problematic since they are variable size issues.. Particular in BZ2StreamScanne
output:
$ make
g++ -O2 -D_LARGEFILE64_
pbzip2.cpp:2999:99: warning: format specifies type 'unsigned int' but the argument has type 'size_t'
(aka 'unsigned long') [-Wformat]
pbzip2.cpp:3943:79: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat]
...fprintf(
pbzip2.cpp:4428:92: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
...limit increased to %d MB to support %d CPUs\n", ((NumBufferedBl
3 warnings generated.
BZ2StreamScanne
BZ2StreamScanne
BZ2StreamScanne
BZ2StreamScanne
4 warnings generated.
Configuration information:
For: pbzip2-1.1.6
iMac Core i5, OS X 10.8.4
$ g++ --version
Configured with: --prefix=
Apple LLVM version 5.0 (clang-500.2.76) (based on LLVM 3.3svn)
Target: x86_64-
Thread model: posix
Related branches
- Yavor Nikolov: Approve
-
Diff: 474 lines (+71/-63)5 files modifiedBZ2StreamScanner.cpp (+15/-13)
BZ2StreamScanner.h (+2/-0)
ChangeLog (+1/-0)
pbzip2.cpp (+50/-50)
pbzip2.h (+3/-0)
Changed in pbzip2: | |
assignee: | nobody → Yavor Nikolov (yavor-nikolov) |
milestone: | none → 1.1.9 |
status: | New → In Progress |
Changed in pbzip2: | |
importance: | Undecided → Low |
status: | In Progress → Fix Committed |
Changed in pbzip2: | |
status: | Fix Committed → Fix Released |
Thanks for reporting this. Is the same reproducible with version 1.1.8?
(These printf statements shouldn't be something critical. Yet - good if we can make it a bit cleaner).
This behaviour depends on compiler (32 or 64-bit and other details). Needs some thinking to figure out what would be the best way to adress the issue. stackoverflow. com/questions/ 2524611/ how-to- print-size- t-variable- portably
A discussion on similar topic is here: http://