PBR

Windows support broken

Bug #1831242 reported by Lucian Petrut
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
PBR
Fix Released
High
Lucian Petrut

Bug Description

A recent commit [1] broke Windows support by using shlex to unquote paths.

The issue with shlex.split is that it doesn't work with Windows paths, treating backslashes as escape characters.

Trace: http://paste.openstack.org/raw/752360/

[1] Id2cc32e4e40c1f834b19756e922118d8526358d3

Changed in pbr:
assignee: nobody → Lucian Petrut (petrutlucian94)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.opendev.org/662450

Changed in pbr:
status: New → In Progress
Ben Nemec (bnemec)
Changed in pbr:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.opendev.org/662450
Committed: https://git.openstack.org/cgit/openstack/pbr/commit/?id=a7e5c0202ea00aab29c009f7adef6cea51ac6e25
Submitter: Zuul
Branch: master

commit a7e5c0202ea00aab29c009f7adef6cea51ac6e25
Author: Lucian Petrut <email address hidden>
Date: Fri May 31 15:06:56 2019 +0300

    Fix Windows support

    A recent commit [1] broke Windows support by using shlex to
    unquote paths.

    The issue with shlex.split is that it doesn't work with Windows
    paths, treating backslashes as escape characters.

    We'll just replace backslashes with slashes before using shlex.split,
    converting them back afterwards.

    Closes-Bug: #1831242

    [1] Id2cc32e4e40c1f834b19756e922118d8526358d3

    Change-Id: Icb3abca004a35ab9760db8116fedfa96d012d0d0

Changed in pbr:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/pbr 5.3.1

This issue was fixed in the openstack/pbr 5.3.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.