PBR

pbr should not discard user-configured suppress_warnings value in sphinx config

Bug #1682467 reported by Doug Hellmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PBR
Fix Released
High
Doug Hellmann
reno
Fix Released
Critical
Doug Hellmann

Bug Description

Commit 2d7c0045f402b31d6223437ba25423eeb32278e1 hard-codes the suppress_warnings setting for sphinx, which means if a user has configured that value already their setting is discarded. That means that, for example, projects that want to ignore the warning about not using remote images in their documentation will have their doc builds break.

http://logs.openstack.org/74/448974/1/check/gate-reno-docs-ubuntu-xenial/bec4a82/console.html

Changed in pbr:
importance: Undecided → High
assignee: nobody → Doug Hellmann (doug-hellmann)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/456683

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

https://review.openstack.org/456687 addresses this in reno and https://review.openstack.org/456683 addresses it in pbr.

Changed in reno:
assignee: nobody → Doug Hellmann (doug-hellmann)
importance: Undecided → Critical
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.openstack.org/456683
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=84a85991339328a188f181385ec4386eb97206dc
Submitter: Jenkins
Branch: master

commit 84a85991339328a188f181385ec4386eb97206dc
Author: Doug Hellmann <email address hidden>
Date: Thu Apr 13 11:51:55 2017 -0400

    add image.nonlocal_uri to the list of warnings ignored

    pbr currently hard-codes the list of warnings that are to be ignored.
    Many OpenStack projects use remote images to add project "badges" based
    on tags defined in the governance repository. Ignore the warning caused
    by using remote images so we can unbreak documentation builds using
    those badges.

    Change-Id: If47e3ca6519cc9f70d62cd887707321fe9199f81
    Addresses-Bug: #1682467
    Signed-off-by: Doug Hellmann <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to reno (master)

Reviewed: https://review.openstack.org/456687
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=079cfc0f74fccfdeb6e2578ab2d85482c42103b8
Submitter: Jenkins
Branch: master

commit 079cfc0f74fccfdeb6e2578ab2d85482c42103b8
Author: Doug Hellmann <email address hidden>
Date: Thu Apr 13 12:02:11 2017 -0400

    comment out openstack governance badges

    Comment out the governance badge link to avoid the warning from using a
    remote image. This can be reverted when a version of pbr with the fix is
    released.

    Addresses-Bug: #1682467
    Change-Id: I9caf5b22d075b4ff3f6be71e23a98f3b5044747c
    Depends-On: If47e3ca6519cc9f70d62cd887707321fe9199f81
    Signed-off-by: Doug Hellmann <email address hidden>

Revision history for this message
Stephen Finucane (stephenfinucane) wrote :

These were fixed, as noted above.

Changed in reno:
status: New → Fix Released
Changed in pbr:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.