PBR

H405 multi line docstring summary not separated with an empty line

Bug #1524176 reported by Luo Gangyi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PBR
Fix Released
Undecided
Luo Gangyi

Bug Description

2015-12-08 16:27:34.687 | ./.eggs/pbr-1.8.1-py2.7.egg/pbr/packaging.py:650:1: H405 multi line docstring summary not separated with an empty line
2015-12-08 16:27:34.688 | """
2015-12-08 16:27:34.688 | ^
2015-12-08 16:27:34.699 | ./.eggs/pbr-1.8.1-py2.7.egg/pbr/core.py:93:1: H405 multi line docstring summary not separated with an empty line
2015-12-08 16:27:34.699 | """

it affects backport to liberty.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/255074

Changed in pbr:
assignee: nobody → Luo Gangyi (luogangyi)
status: New → In Progress
Revision history for this message
Robert Collins (lifeless) wrote :

Sorry what? I am confused. We don't (cannot) branch pbr, nor do backports of it.

Revision history for this message
Luo Gangyi (luogangyi) wrote :

@Robert, Actually I am confused too. I submit a patch to project gnocchi, everything is OK, but when I backport it to stable/1.3, I got the above value in jenkins see http://logs.openstack.org/40/253540/1/check/gate-gnocchi-pep8/2dee1ad/console.html

Revision history for this message
Luo Gangyi (luogangyi) wrote :

I see, seems the problem of configuration of tox.ini.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to pbr (master)

Reviewed: https://review.openstack.org/255074
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=768c53474ddaf78e6e89f56b36ac3273a6031b0a
Submitter: Jenkins
Branch: master

commit 768c53474ddaf78e6e89f56b36ac3273a6031b0a
Author: Luo Gangyi <email address hidden>
Date: Tue Dec 8 21:37:49 2015 -0800

    Enable pep8 H405 tests

    Enabled H405 multi line docstring summary not separated with an empty
    line in tox testing.

    Change-Id: I1a4bfbd2bad6eb2c132843ca21451807737121df
    Closes-Bug:#1524176

Changed in pbr:
status: In Progress → Fix Released
Revision history for this message
Robert Collins (lifeless) wrote :

That gnocchi job is running oddly: its installing pbr via easy-install, which leads to potential flakiness as easy-install is involved. I recommend getting infra input to understand why that is happening. The pbr code is being assessed by flake8 because of easy-install's use.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack-dev/pbr 1.9.0

This issue was fixed in the openstack-dev/pbr 1.9.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.