PBR

integration.sh - git diff --quiet not detecting changes

Bug #1410434 reported by Steve McLellan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PBR
Confirmed
Medium
Steve McLellan

Bug Description

We're seeing an issue with an admittedly old version of git (1.7.9.5) where the check in integration.sh to detect changes to requirements is not returning the expected value, and thus the changes are being discarded.

This issue was noted in devstack in https://bugs.launchpad.net/devstack/+bug/1264422, and fixed in https://review.openstack.org/#/c/68546/ by changing to (cd $project_dir && git diff --exit-code >/dev/null).

I'm trying to determine if the --quiet issue is still a problem but perhaps it's worth making this change anyway, since --quiet shortcuts some things and thus i'm not sure should be trusted.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/146958

Changed in pbr:
assignee: nobody → Steve McLellan (sjmc7)
status: New → In Progress
Robert Collins (lifeless)
Changed in pbr:
importance: Undecided → Medium
Davanum Srinivas (DIMS) (dims-v)
Changed in pbr:
status: In Progress → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on pbr (master)

Change abandoned by ChangBo Guo(gcb) (<email address hidden>) on branch: master
Review: https://review.openstack.org/146958
Reason: No update for two years, please restore it if you want to continue working on this.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.