PBR

non-release related tags causing version skew

Bug #1403124 reported by Dave Walker on 2014-12-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	PBR	Fix Released	Undecided	Robert Collins

Bug Description

Adding a tag to a branch that is not in a release style format should be accepted and not cause build version skew.

Currently, if I add a tag such as 'non-release-tag/2014.12.16-1' it yields a release version of 12.16.1.dev1.g* (see the date substring hijacked out of the non-release tag?)

This tag is clearly not release related, and should therefore be ignored.

See original description

Dave Walker (davewalker) on 2014-12-16

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-12-16: Fix proposed to pbr (master)

Fix proposed to branch: master
Review: https://review.openstack.org/142144

Changed in pbr:
assignee:	nobody → Dave Walker (davewalker)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2015-04-16

Changed in pbr:
assignee:	Dave Walker (davewalker) → Robert Collins (lifeless)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-04-17: Fix merged to pbr (master)

Reviewed: https://review.openstack.org/142144
Committed: https://git.openstack.org/cgit/openstack-dev/pbr/commit/?id=1b4a8bd554a65384638f06d556d8d0063800c080
Submitter: Jenkins
Branch: master

commit 1b4a8bd554a65384638f06d556d8d0063800c080
Author: Dave Walker (Daviey) <email address hidden>
Date: Tue Dec 16 16:07:58 2014 +0000

Ignore non-release related tags

    Previously we were accepting many string tags to be release
    tags for versions. This change enforces tags that are
    considered to start with a digit, and ignore if not.

    Change-Id: Ib1ca0eda62e375cdee70d35ed7c82a544082ef0a
    Closes-bug: 1403124
    Signed-off-by: Dave Walker (Daviey) <email address hidden>