deployment fails if container volume source is a docker/podman volume and not a filesystem path

[Alex Schultz]

Both docker and podman support using a volume name as part of a volume mount. We added logic into paunch to throw an error if the source didn't exist and we assumed it was always a file system path. Since this can also be container volume, we need to adjust the logic to handle checking for container volumes.

https://review.opendev.org/#/c/672239/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/681789

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.opendev.org/681790

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/681791

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/681791
Reason: meh we'll need to rework this rather than revert for stein/master because of podman

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/682141

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681790
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=3ea0f8197170e374f54dc79e336f4382fe0bfcd7
Submitter: Zuul
Branch: stable/rocky

commit 3ea0f8197170e374f54dc79e336f4382fe0bfcd7
Author: Alex Schultz <email address hidden>
Date: Thu Sep 12 15:56:07 2019 +0000

    Revert "Check if volume paths exist before executing Docker."

    This reverts commit 23154b26d57e4f25456b1f43bc5dff5fb373fc9e.

    Change-Id: I8e1c753c22ba1304ab64b64a40cbfc758ac1861f
    Related-Bug: #1843734

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/681789
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=aa359be1df1832a817118ad2efd1fedad946ea3e
Submitter: Zuul
Branch: stable/queens

commit aa359be1df1832a817118ad2efd1fedad946ea3e
Author: Alex Schultz <email address hidden>
Date: Thu Sep 12 15:55:50 2019 +0000

    Revert "Check if volume paths exist before executing Docker."

    This reverts commit 85c1bc9d15acaaf9156991ea57b17d0922329af5.

    Change-Id: Iff17da926ca5bab78bec3ab7245109e9b1dca748
    Related-Bug: #1843734

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/682141
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=3ce8c1ad988872234225fb3d316375c0e8ebcb36
Submitter: Zuul
Branch: master

commit 3ce8c1ad988872234225fb3d316375c0e8ebcb36
Author: Alex Schultz <email address hidden>
Date: Fri Sep 13 13:12:30 2019 -0600

    Improve volume validation

    We need to support both a source filesystem location and container
    volume for the volume mounts. This change adds the ability to validate
    that the provided source container is a container volume. Additionally
    aligns the validation between the docker/podman methods so they operate
    in the same fashion.

    Change-Id: I9a55698b04dc2c5f01d776c6bdc2f26d47baf803
    Closes-Bug: #1843734

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/683386

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683386
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=50e5f4412ac9e61c0359517497154dcaf431a6f2
Submitter: Zuul
Branch: stable/stein

commit 50e5f4412ac9e61c0359517497154dcaf431a6f2
Author: Alex Schultz <email address hidden>
Date: Fri Sep 13 13:12:30 2019 -0600

    Improve volume validation

    We need to support both a source filesystem location and container
    volume for the volume mounts. This change adds the ability to validate
    that the provided source container is a container volume. Additionally
    aligns the validation between the docker/podman methods so they operate
    in the same fashion.

    Change-Id: I9a55698b04dc2c5f01d776c6bdc2f26d47baf803
    Closes-Bug: #1843734
    (cherry picked from commit 3ce8c1ad988872234225fb3d316375c0e8ebcb36)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch 5.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch 4.5.2 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/686441
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c1f7facac0022904cfd0d1113fee5257ca0db7e0
Submitter: Zuul
Branch: master

commit c1f7facac0022904cfd0d1113fee5257ca0db7e0
Author: Alex Schultz <email address hidden>
Date: Thu Oct 3 10:32:20 2019 -0600

    Add an experimental test container volume create service

    This adds a test volume service that can be used to create a basic
    container volume on the host during step 2. This volume has been
    added to the scenario002 standalone to exercise thie opt volume
    configurations that we expose for heat.

    Related-Bug: #1843734
    Change-Id: Ia8fa1750bbd9a9b528050e074e55005af480b4f5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/742751

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742751
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=e13226d4cf279071a07d7196c3e631d004031a1b
Submitter: Zuul
Branch: stable/queens

commit e13226d4cf279071a07d7196c3e631d004031a1b
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 23 17:04:14 2020 -0400

    [queens-only] Improve volume validation (unclean backport)

    Manually backport I9a55698b04dc2c5f01d776c6bdc2f26d47baf803.

    We need to support both a source filesystem location and container
    volume for the volume mounts. This change adds the ability to validate
    that the provided source container is a container volume. Additionally
    aligns the validation between the docker/podman methods so they operate
    in the same fashion.

    Change-Id: Id42eb9d550865682078781a04f961c13bfbcde78
    Closes-Bug: #1843734

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/paunch queens-eol release.