Paunch logging should be improved

Bug #1799182 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Bogdan Dobrelya

Bug Description

It should log to file and console, using oslo_log, like tripleo client does.
Otherwise it's hard to debug things going on by paunch

Changed in tripleo:
importance: Undecided → Medium
tags: added: tech-debt ux
Changed in tripleo:
milestone: none → stein-1
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Would be also nice to have the class names logged, see https://review.openstack.org/#/c/599346

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (master)

Fix proposed to branch: master
Review: https://review.openstack.org/612308

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/612948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (master)

Reviewed: https://review.openstack.org/612308
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=d3c83259bfe59ed6713c7b5f7bb34128f39aae24
Submitter: Zuul
Branch: master

commit d3c83259bfe59ed6713c7b5f7bb34128f39aae24
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Oct 22 12:22:10 2018 +0200

    Fix logging to stdout and file in classes/commands

    Fix logging to console to depend on input CLI args. By default, keep
    logging to stdout. Make --log-file argument working as well.

    Use the input verbosity parameters as a controlling switch for
    logs verbosity.

    Evaluate log levels as:

      * 1 (WARNING+) - the default log level if neither -v nor --debug used
      * 2 (INFO+) - applies if -v / --verbose
      * 4 (DEBUG+) - applies if --debug, dumps command results to file,
        if --log-file is requested.
      * 5 (DEBUG+) - applies if --debug and -v. Like the latter mode, but
        also dumps the executed commands results to console.

    This is needed for better deployments troubleshootng.

    Closes-Bug: #1799182

    Change-Id: I653ac4cc520e40f3eb4d029e8c99ab482b17a859
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/614166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (master)

Reviewed: https://review.openstack.org/614166
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=791766596c49278787226c6de6fea576098d8b45
Submitter: Zuul
Branch: master

commit 791766596c49278787226c6de6fea576098d8b45
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Oct 30 11:04:32 2018 +0100

    Log to a file by default, unless debugging

    By default, log paunch to /var/log/paunch.log.

    Related-Bug: #1799182

    Change-Id: Ib0685eb72becb867452bef17f17ab8e3d5b7d931
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch 4.1.0

This issue was fixed in the openstack/paunch 4.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/612948
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c5d1b6fb6300c131cdb3fec76193d74673cd6fdc
Submitter: Zuul
Branch: master

commit c5d1b6fb6300c131cdb3fec76193d74673cd6fdc
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Oct 24 10:40:48 2018 +0200

    Fix paunch logs verbosity control

    Make ConfigDebug also controlling the paunch logs verbosity.

    Depends-On: https://review.openstack.org/614166
    Related-Bug: #1799182

    Change-Id: I89fd73eaa2120f06ab245be148a60bb08f0cb512
    Signed-off-by: Bogdan Dobrelya <email address hidden>

tags: added: queens-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/702434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/702438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/queens)

Reviewed: https://review.opendev.org/702434
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=059aa8c1f66337bc927db7aefde5639fc70ecf5f
Submitter: Zuul
Branch: stable/queens

commit 059aa8c1f66337bc927db7aefde5639fc70ecf5f
Author: Bogdan Dobrelya <email address hidden>
Date: Mon Oct 22 12:22:10 2018 +0200

    Fix logging to stdout and file in classes/commands

    Fix logging to console to depend on input CLI args. By default, keep
    logging to stdout. Make --log-file argument working as well.

    Use the input verbosity parameters as a controlling switch for
    logs verbosity.

    Evaluate log levels as:

      * 1 (WARNING+) - the default log level if neither -v nor --debug used
      * 2 (INFO+) - applies if -v / --verbose
      * 4 (DEBUG+) - applies if --debug, dumps command results to file,
        if --log-file is requested.
      * 5 (DEBUG+) - applies if --debug and -v. Like the latter mode, but
        also dumps the executed commands results to console.

    This is needed for better deployments troubleshootng.

    Closes-Bug: #1799182

    Change-Id: I653ac4cc520e40f3eb4d029e8c99ab482b17a859
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit d3c83259bfe59ed6713c7b5f7bb34128f39aae24)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/queens)

Reviewed: https://review.opendev.org/702438
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=1c590fc76d62200cdf247e2a6638873f1430b353
Submitter: Zuul
Branch: stable/queens

commit 1c590fc76d62200cdf247e2a6638873f1430b353
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Oct 30 11:04:32 2018 +0100

    Log to a file by default, unless debugging

    By default, log paunch to /var/log/paunch.log.

    Related-Bug: #1799182

    Change-Id: Ib0685eb72becb867452bef17f17ab8e3d5b7d931
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 791766596c49278787226c6de6fea576098d8b45)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch queens-eol

This issue was fixed in the openstack/paunch queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.