tripleo

paunch --label does not work

Bug #1798362 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz
tripleo stein-1

Bug Description

The --label foo=bar argument fails processing as it takes the string value and treats it as a list.
It should be fixed to either get a comma-separated list, e.g. --label foo=bar,baz=qux, or to multi-arg values, like --label foo=bar --lable baz=qux.

Bogdan Dobrelya (bogdando)
Changed in tripleo:
milestone: none → stein-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (master)

Fix proposed to branch: master
Review: https://review.openstack.org/611298

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: Bogdan Dobrelya (bogdando) → James Slagle (james-slagle)
assignee: James Slagle (james-slagle) → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (master)

Reviewed: https://review.openstack.org/611298
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=b28914702ae5e83d3e3922e1690acb3ef95a167b
Submitter: Zuul
Branch: master

commit b28914702ae5e83d3e3922e1690acb3ef95a167b
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Oct 17 14:03:52 2018 +0200

    Fix labels to take multiple values

    Closes-Bug: #1798362
    Change-Id: I635e7d53f8aea63c05a2e5565f2a2ab40dcd38f8
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch 4.2.0

This issue was fixed in the openstack/paunch 4.2.0 release.

Bogdan Dobrelya (bogdando)
tags: added: queens-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/702435

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/queens)

Reviewed: https://review.opendev.org/702435
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=f12e6da460543c8677f256ff93c5b1fecad5f674
Submitter: Zuul
Branch: stable/queens

commit f12e6da460543c8677f256ff93c5b1fecad5f674
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Oct 17 14:03:52 2018 +0200

    Fix labels to take multiple values

    Closes-Bug: #1798362
    Change-Id: I635e7d53f8aea63c05a2e5565f2a2ab40dcd38f8
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit b28914702ae5e83d3e3922e1690acb3ef95a167b)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/718459

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/stein)

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/718460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/718463

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Apparently, while containers automatic-applying by paunch works just fine with that fix as of Stein, there are more cases to be addressed for manual patching/debugging scenarios involving multiple labels. That is 'debug' actions run/print-cmd to catch up the multi-lable fix as well.

Changed in tripleo:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to paunch (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/718688

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (master)

Reviewed: https://review.opendev.org/718688
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=21c32c8c609a87c3d84b2bfb5e00e415baddb98e
Submitter: Zuul
Branch: master

commit 21c32c8c609a87c3d84b2bfb5e00e415baddb98e
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Apr 8 15:48:14 2020 +0200

    Process labels before building container run args

    The consistent way of building container run arguments is processing
    labels (possibly multiple) first.

    Fix 'debug' actions 'run' and 'print-cmd' to not falling behind of that
    pattern already proved working well for containers 'apply'.

    Change-Id: I771d086cc75695d7ce2db35c852bb35bb4c59708
    Related-Bug: #1798362
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/train)

Reviewed: https://review.opendev.org/718459
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=db149de244d674e4bdfebc4a9576fd66814195a0
Submitter: Zuul
Branch: stable/train

commit db149de244d674e4bdfebc4a9576fd66814195a0
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Apr 8 15:48:14 2020 +0200

    Process labels before building container run args

    The consistent way of building container run arguments is processing
    labels (possibly multiple) first.

    Fix 'debug' actions 'run' and 'print-cmd' to not falling behind of that
    pattern already proved working well for containers 'apply'.

    Change-Id: I771d086cc75695d7ce2db35c852bb35bb4c59708
    Related-Bug: #1798362
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 21c32c8c609a87c3d84b2bfb5e00e415baddb98e)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/queens)

Reviewed: https://review.opendev.org/718463
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=f294ce2b1193c8d927ba03b0c973bdd1f1db0b52
Submitter: Zuul
Branch: stable/queens

commit f294ce2b1193c8d927ba03b0c973bdd1f1db0b52
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Apr 8 15:48:14 2020 +0200

    Process labels before building container run args

    The consistent way of building container run arguments is processing
    labels (possibly multiple) first.

    Fix 'debug' actions 'run' and 'print-cmd' to not falling behind of that
    pattern already proved working well for containers 'apply'.

    Change-Id: I771d086cc75695d7ce2db35c852bb35bb4c59708
    Related-Bug: #1798362
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 6423f9d6eee9bf22f30ff7a7b5d92c6a06112625)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to paunch (stable/stein)

Reviewed: https://review.opendev.org/718460
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=d2f7423718c7829a5d0ae029103ee6b4f3b41a07
Submitter: Zuul
Branch: stable/stein

commit d2f7423718c7829a5d0ae029103ee6b4f3b41a07
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Apr 8 15:48:14 2020 +0200

    Process labels before building container run args

    The consistent way of building container run arguments is processing
    labels (possibly multiple) first.

    Fix 'debug' actions 'run' and 'print-cmd' to not falling behind of that
    pattern already proved working well for containers 'apply'.

    Change-Id: I771d086cc75695d7ce2db35c852bb35bb4c59708
    Related-Bug: #1798362
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 6423f9d6eee9bf22f30ff7a7b5d92c6a06112625)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch queens-eol

This issue was fixed in the openstack/paunch queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.