Merge rbac_auth with rbac_rule_validation

Bug #1681459 reported by Felipe Monteiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Patrole
Fix Released
Wishlist
Felipe Monteiro

Bug Description

Currently, rbac_auth doesn't do much: It decentralizes logic that can be easily merged into rbac_rule_validation without doing anything authentication-related. All rbac_auth does is:
  1) Construct RbacPolicyParser and check whether a given role is allowed to perform a given policy action.
  2) Dump some info to LOG
  3) Catch some exceptions

Thus, there's no justification for keeping rbac_auth. It doesn't provide a high-enough level of abstraction to warrant being used. It should be removed and its logic inserted in rbac_rule_validation.

Felipe Monteiro (fm577c)
Changed in patrole:
importance: Undecided → Wishlist
Felipe Monteiro (fm577c)
summary: - Merged rbac_auth with rbac_rule_validation
+ Merge rbac_auth with rbac_rule_validation
Felipe Monteiro (fm577c)
Changed in patrole:
assignee: nobody → Felipe Monteiro (fm577c)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to patrole (master)

Reviewed: https://review.openstack.org/456384
Committed: https://git.openstack.org/cgit/openstack/patrole/commit/?id=78fc4895be73245937414611079d03a1e8a2132f
Submitter: Jenkins
Branch: master

commit 78fc4895be73245937414611079d03a1e8a2132f
Author: Felipe Monteiro <email address hidden>
Date: Wed Apr 12 21:33:39 2017 +0100

    Merge rbac_auth with rbac_rule_validation

    Currently, rbac_auth doesn't do much: It decentralizes logic
    that can be easily merged into rbac_rule_validation without
    doing anything authentication-related. All rbac_auth does is:

      1) Construct RbacPolicyParser and check whether a given role
         is allowed to perform a given policy action.
      2) Dump some info to LOG
      3) Catch some exceptions

    Thus, there's no justification for keeping rbac_auth. It doesn't
    provide a high-enough level of abstraction to warrant being used.
    It should be removed and its logic inserted in rbac_rule_validation.

    Change-Id: I756175ea28ec11f24150f46d5ae4c2f64499a0ea
    Closes-Bug: #1681459

Changed in patrole:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.