Merge rbac_auth with rbac_rule_validation
Bug #1681459 reported by
Felipe Monteiro
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Patrole |
Fix Released
|
Wishlist
|
Felipe Monteiro |
Bug Description
Currently, rbac_auth doesn't do much: It decentralizes logic that can be easily merged into rbac_rule_
1) Construct RbacPolicyParser and check whether a given role is allowed to perform a given policy action.
2) Dump some info to LOG
3) Catch some exceptions
Thus, there's no justification for keeping rbac_auth. It doesn't provide a high-enough level of abstraction to warrant being used. It should be removed and its logic inserted in rbac_rule_
Changed in patrole: | |
importance: | Undecided → Wishlist |
summary: |
- Merged rbac_auth with rbac_rule_validation + Merge rbac_auth with rbac_rule_validation |
Changed in patrole: | |
assignee: | nobody → Felipe Monteiro (fm577c) |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/456384 /git.openstack. org/cgit/ openstack/ patrole/ commit/ ?id=78fc4895be7 324593741461107 9d03a1e8a2132f
Committed: https:/
Submitter: Jenkins
Branch: master
commit 78fc4895be73245 937414611079d03 a1e8a2132f
Author: Felipe Monteiro <email address hidden>
Date: Wed Apr 12 21:33:39 2017 +0100
Merge rbac_auth with rbac_rule_ validation
Currently, rbac_auth doesn't do much: It decentralizes logic validation without related. All rbac_auth does is:
that can be easily merged into rbac_rule_
doing anything authentication-
1) Construct RbacPolicyParser and check whether a given role
is allowed to perform a given policy action.
2) Dump some info to LOG
3) Catch some exceptions
Thus, there's no justification for keeping rbac_auth. It doesn't validation.
provide a high-enough level of abstraction to warrant being used.
It should be removed and its logic inserted in rbac_rule_
Change-Id: I756175ea28ec11 f24150f46d5ae4c 2f64499a0ea
Closes-Bug: #1681459