Admin role is always assumed to be 'admin'

[Felipe Monteiro]

Currently, the Patrole framework always assumes that the admin role is "admin". But this might not necessarily be the case. The word "admin" is just a convention, but is nonetheless an arbitrary designation for administration privileges.

Instead, the Patrole framework should take advantage of the already-existing Tempest conf option:

    cfg.StrOpt('admin_role',
               default='admin',
               help="Role required to administrate keystone."),

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462734
Committed: https://git.openstack.org/cgit/openstack/patrole/commit/?id=f6b69e23b95d5348a19774ed14f14b53b52b1452
Submitter: Jenkins
Branch: master

commit f6b69e23b95d5348a19774ed14f14b53b52b1452
Author: Felipe Monteiro <email address hidden>
Date: Thu May 4 21:55:04 2017 +0100

    Change "admin" literal for admin role to CONF admin_role

    Currently, the Patrole framework always assumes that the admin
    role is "admin". But this might not necessarily be the case.
    The word "admin" is just a convention, but is nonetheless an
    arbitrary designation for administration privileges.

    Instead, the Patrole framework should take advantage of the
    already-existing Tempest configuration option:

        cfg.StrOpt('admin_role',
                   default='admin',
                   help="Role required to administrate keystone."),

    This patch changes instances of 'admin' (for identifying the
    admin role) with ``CONF.identity.admin_role``. This patch doesn't
    make changes to 'admin' in unit tests, as that's not necessary,
    but instead uses ``CONF.set_override`` to change the ``admin_role``
    to "admin".

    Closes-Bug: #1680294
    Change-Id: Ia4431c2a16892a60fe10bb7e8495e7e384e552c1