certain subfolder entries without user entries give python traceback

Bug #1384710 reported by Steve Beattie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pasaffe
Fix Released
Undecided
Unassigned

Bug Description

Clicking or right-clicking on entries that don't have an entry in the user field will generate a python traceback and the Copy {Url,User,Password} options will all be greyed out:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/pasaffe/PasaffeWindow.py", line 665, in on_treeview1_cursor_changed
    self.display_data(entry_uuid)
  File "/usr/lib/python3/dist-packages/pasaffe/PasaffeWindow.py", line 524, in display_data
    self.passfile.records[entry_uuid].get(4))
  File "/usr/lib/python3/dist-packages/gi/overrides/Gtk.py", line 715, in insert
    raise TypeError('text must be a string, not %s' % type(text))
TypeError: text must be a string, not <class 'NoneType'>

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :
Changed in pasaffe:
status: New → Fix Committed
Revision history for this message
Steve Beattie (sbeattie) wrote :

After manually applying commit 595 to my pasaffe install, I'm no longer seeing these backtraces and the menu options remain available (though offering to copy the empty username is a bit useless). I'm not seeing any other issues with pasaffe with this patch applied.

Thanks!

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Ah great, thanks!

Good point about the menu entry when the field is blank, I'll fix that.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Menus disabled when entries are blank in r603

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Released 0.40

Changed in pasaffe:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.