ntfs-3g has changed api

Bug #509172 reported by Treeve Jelbert
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
partimage-ng
Fix Committed
Undecided
Unassigned

Bug Description

ntfs-3g-2009.11.14 and 2010.1.16 have introduced an extra parameter for ntfs_get_size_for_mapping_pairs

the attached patch fixes the problem

it applies against trunk, rev 85

Revision history for this message
Treeve Jelbert (treeve) wrote :
  • nt Edit (1.1 KiB, text/plain)
Revision history for this message
Dmitry Ivanov (vonami) wrote :

Yeah, that's bad news, also see bug #505356. But thanks for the patch. I'm waiting for a reply from the ntfs-3g devs regarding API/binary compatibility for libntfs-3g. I'm afraid we might end up with lots of checks and defines for every incompatible libtntfs-3g version.

Revision history for this message
Dmitry Ivanov (vonami) wrote :

The patch with additional checks is committed in trunk@86.

Changed in partimage-ng:
status: New → Fix Committed
Revision history for this message
Andrey Gusev (gauss-gs) wrote :

Looks like this happens again:

gauss@pmain:~/Projects/partimage-ng$ bzr revno
88

gauss@pmain:~$ apt-cache policy libntfs-3g-dev
libntfs-3g-dev:
  Installed: 1:2010.3.6-1ubuntu1
  Candidate: 1:2010.3.6-1ubuntu1
  Version table:
 *** 1:2010.3.6-1ubuntu1 0
        500 http://ru.archive.ubuntu.com/ubuntu/ lucid/main Packages
        100 /var/lib/dpkg/status
     1:2010.3.6-1 0
        500 http://ftp.de.debian.org/debian/ squeeze/main Packages

gauss@pmain:~/Projects/partimage-ng$ make -j8
[ 4%] Building C object libpartimage-ng/src/CMakeFiles/partimage-ng.dir/filesystems/ntfsfilesystem_c.c.o
In file included from /usr/include/ntfs-3g/inode.h:35,
                 from /usr/include/ntfs-3g/volume.h:72,
                 from /home/gauss/Projects/partimage-ng/libpartimage-ng/src/filesystems/ntfsfilesystem_c.c:29:
/usr/include/ntfs-3g/ntfstime.h:43: error: redefinition of 'struct timespec'
/home/gauss/Projects/partimage-ng/libpartimage-ng/src/filesystems/ntfsfilesystem_c.c: In function 'partimage_ng_ntfs_clear_badblocks_map':
/home/gauss/Projects/partimage-ng/libpartimage-ng/src/filesystems/ntfsfilesystem_c.c:304: warning: format '%lld' expects type 'long long int', but argument 3 has type 'VCN'
/home/gauss/Projects/partimage-ng/libpartimage-ng/src/filesystems/ntfsfilesystem_c.c:304: warning: format '%lld' expects type 'long long int', but argument 4 has type 'LCN'
/home/gauss/Projects/partimage-ng/libpartimage-ng/src/filesystems/ntfsfilesystem_c.c:304: warning: format '%lld' expects type 'long long int', but argument 5 has type 's64'
make[2]: *** [libpartimage-ng/src/CMakeFiles/partimage-ng.dir/filesystems/ntfsfilesystem_c.c.o] Error 1
make[1]: *** [libpartimage-ng/src/CMakeFiles/partimage-ng.dir/all] Error 2
make: *** [all] Error 2

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.