PATCH : Adding SSH Agent forwarding basic support

Bug #483697 reported by Caeies
84
This bug affects 16 people
Affects Status Importance Assigned to Milestone
paramiko
New
Undecided
Unassigned

Bug Description

Hi all,

Please, find enclosed a proposed patch for supporting SSH Agent forwarding. From my git log :

    Adding basic support for SSH Forwarding agent.

       * Client is able to ask and forward ssh agent.
       * Server is able to use and ask a forwading agent.
       * Server create a dummy local agent for use by other client from this
         side. NOTE : this one is still buggy, we need to be able to answer
         to more than one client !!!

I'm not happy with the way the agent.py was modified ... If people have suggestions, I'm open to them !

Hope this will be usefull.

Revision history for this message
Chris Vigelius (chris-vigelius) wrote :

for what it's worth, voting +1 on this one - it would be very useful to have this ability in fabric (which is based on Paramiko).

Revision history for this message
Syver Enstad (syver-enstad) wrote :

+1 for paramiko agent forwarding support

Revision history for this message
Antti Kaihola (akaihola) wrote :

Great! This patch would get rid of needing to use this work-around:

http://lincolnloop.com/blog/2009/sep/22/easy-fabric-deployment-part-1-gitmercurial-and-ssh/

Revision history for this message
Caeies (caeies) wrote :
Revision history for this message
Caeies (caeies) wrote :

I have updated the patch (but the code is the same as the previous one) for helping people applying it. Looks like the first one was not well formed.

Hope this helps.

I'm still open to better solutions :).

./test.py succeed with this test.

Regards

Caeies.

Revision history for this message
Georgiy Miroshnikov (laggy-luke) wrote :

Hey Caeies,

That's a great new year present! :)

Maybe you could just fork paramiko on github and apply your patch?
I did this with your initial patch, but I was only interested in client, so my fork is not complete.

It would also be great if you could provide some basic usage examples, because couldn't make use of your patch without changing paramiko sources.

But anyway, thanks a lot!

Revision history for this message
brainstorm (brainstorm) wrote :

Caeies, I just pull requested your new patch to robey, I'm really looking forward to see it integrated since I need it for pyfabric :)

romanvg@biobit:~/dev/paramiko$ ./test.py
............................................................................................................ 10s 8s ......... 4s 1s ......... 9s ......... 5s ......... ........ ......... ......... ...
----------------------------------------------------------------------
Ran 109 tests in 117.969s

OK

Revision history for this message
Klaas van Schelven (klaas-vanschelven) wrote :

I've applied the patch as found on GitHub, but it does not work for me. Also, because of the lack of documentation, it's not clear to me how it should work.

Is there anything I need to do to make Fabric actually use the agent forwarding?

Agent forwarding "manually" with "ssh -A" works fine for me, but that doesn't work in Fabric.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.