window dimensions should be saved immediately, not only when closing a window

Bug #1406439 reported by Avi Romanoff
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Terminal
Fix Released
Wishlist
Djax

Bug Description

pantheon-terminal opens new windows with the same width and height of the last saved dimensions in GSettings. However, those values are only updated after a terminal window closes. That's bad behavior -- the GSettings dimensions should be the dimensions of the last-resized window, whether or not its been closed yet or not.

Related branches

Revision history for this message
Danielle Foré (danrabbit) wrote :

The problem, as discussed, is this:

1. Last window size was something really big
2. Resize to a smaller window
3. Open a new terminal window

Expectation:
4. New terminal window is small

Reality
5. New terminal window is really big

Changed in pantheon-terminal:
status: New → Confirmed
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

I've noticed this as well. Is there any reason we can't update GSettings after a resize? Perhaps with a delay after they stop resizing of a second or so we don't spam GSettings if someone is actively resizing a window.

Revision history for this message
Djax (parnold-x) wrote :

See the linked branch

Cody Garver (codygarver)
Changed in pantheon-terminal:
importance: Undecided → Wishlist
milestone: none → loki-beta1
status: Confirmed → In Progress
mporten (mathias-porten)
Changed in pantheon-terminal:
assignee: nobody → Djax (parnold-x)
Cody Garver (codygarver)
Changed in pantheon-terminal:
milestone: loki-beta1 → loki-alpha1
status: In Progress → Fix Committed
Changed in pantheon-terminal:
milestone: loki-beta1 → 0.4
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.