Terminal

CMake doesn't honor CPPFLAGS

Bug #1325329 reported by Sergey "Shnatsel" Davidoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Slingshot
New
Undecided
Unassigned
Terminal
Fix Released
Undecided
Sergey "Shnatsel" Davidoff

Bug Description

CMake doesn't honor CPPFLAGS (C preprocessor flags) environment variable. Because of this not all Debian hardening options are applied, in particular "-D_FORTIFY_SOURCE=2" is not applied.

Most elementary applications as well as the example at http://elementaryos.org/docs/code/the-build-system seem to be affected.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

The quick fix I've devised so far is adding the following line to CMakeLists.txt:
    add_definitions (${CPPFLAGS})

I have no idea if this is the proper way to fix that.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Interestingly enough, Maya doesn't seem to be affected.

Sergey "Shnatsel" Davidoff (shnatsel)
Changed in pantheon-terminal:
assignee: nobody → Sergey "Shnatsel" Davidoff (shnatsel)
status: New → Fix Committed
David Gomes (davidgomes)
Changed in pantheon-terminal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.