Use CSD Titlebar

Bug #1288048 reported by Danielle Foré
30
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Audience
Fix Released
Wishlist
Danielle Foré
Eidete
Fix Released
Wishlist
Fabio Zaramella
Terminal
Fix Released
Low
Danielle Foré

Bug Description

as of gtk 3.11.8 dialogs are now using CSD Titlebars. Not headerbar, but titlebar. This must be available to regular apps.

We should investigate and look into implementing CSD Titlebar since it doesn't come with the padding/style associated with headerbar.

Related branches

Revision history for this message
Danielle Foré (danrabbit) wrote :

Adding Midori just so Christian has the option to decide whether to go full headerbar or just titlebar

Revision history for this message
Cris Dywan (kalikiana) wrote :

Though bug 1232558 has a proof of concept and some bits and pieces of ideas it's still blocking on three points:
- There's no universal way of knowing whether to enable the headerbar/titlebar - Midori is cross-platform, it can't enable it when running on a system where nothing else uses headerbars and the theme may not even support it. Not sure how valid that is for the other apps affected here.
- The design is still unclear - Epiphany seems to accept that the urlbar is very small as a side effect of being inside the header. That to me is a big concern.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Relevant snippet from Matthias Clasen about how they do this in gtk.dialog:

 GtkWidget *label;

box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
gtk_widget_show (box);
gtk_widget_set_size_request (box, -1, 16);
label = gtk_label_new ("");
gtk_widget_set_margin_top (label, 6);
gtk_widget_set_margin_bottom (label, 6);
gtk_style_context_add_class (gtk_widget_get_style_context (label), "title");
gtk_box_set_center_widget (GTK_BOX (box), label);
 g_signal_connect_object (dialog, "notify::title", G_CALLBACK (update_title), label, 0);

gtk_window_set_titlebar (GTK_WINDOW (dialog), box);

Cody Garver (codygarver)
Changed in audience:
importance: Undecided → Wishlist
milestone: none → isis-beta1
status: New → Confirmed
Cody Garver (codygarver)
Changed in audience:
milestone: isis-beta1 → isis-beta2
Changed in pantheon-terminal:
status: Confirmed → In Progress
assignee: nobody → Daniel Fore (danrabbit)
milestone: none → isis-beta1
Cody Garver (codygarver)
Changed in pantheon-terminal:
status: In Progress → Fix Committed
Changed in pantheon-terminal:
status: Fix Committed → Fix Released
Changed in audience:
status: Confirmed → In Progress
Changed in audience:
status: In Progress → New
Changed in audience:
status: New → In Progress
assignee: nobody → Daniel Fore (danrabbit)
Changed in eidete:
status: New → In Progress
assignee: nobody → Fabio Zaramella (ffabio-96-x)
Cody Garver (codygarver)
Changed in eidete:
importance: Undecided → Wishlist
Changed in audience:
assignee: Daniel Fore (danrabbit) → Fabio Zaramella (ffabio-96-x)
Changed in audience:
assignee: Fabio Zaramella (ffabio-96-x) → nobody
Cody Garver (codygarver)
Changed in audience:
assignee: nobody → Daniel Fore (danrabbit)
Cody Garver (codygarver)
Changed in audience:
milestone: freya-beta2 → freya-beta1
Cody Garver (codygarver)
Changed in audience:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in eidete:
status: In Progress → Fix Released
no longer affects: midori
Changed in audience:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.