Ugly margins in dialogs since Gtk+-3.14
Bug #1411808 reported by
Marcus Wichelmann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Eidete |
Fix Committed
|
Undecided
|
Marcus Wichelmann | ||
Maya |
Fix Released
|
Low
|
Corentin Noël | ||
Noise |
Fix Released
|
Undecided
|
Marcus Wichelmann | ||
Photos |
Fix Released
|
Undecided
|
Fabio Zaramella | ||
Scratch |
Fix Released
|
Low
|
Marcus Wichelmann |
Bug Description
Since the update to Gtk+-3.14 the margins of some dialogs are too small. That indication-error is caused by the "Object (use_header_bar: 1);"-workaround to hide the close-buttons.
To fix that remove theese lines:
Object (use_header_bar: 1);
(this.get_
this.get_header_bar ().get_
And replace them with:
this.deletable = false;
Related branches
lp:~l-admin-3/scratch/dialog-margins
- elementary Apps team: Pending requested
-
Diff: 28 lines (+2/-6)1 file modifiedsrc/Dialogs/PreferencesDialog.vala (+2/-6)
lp:~l-admin-3/noise/dialog-margins
- elementary Apps team: Pending requested
-
Diff: 183 lines (+11/-32)6 files modifiedsrc/Dialogs/FileNotFoundDialog.vala (+2/-7)
src/Dialogs/InstallGstreamerPluginsDialog.vala (+2/-7)
src/Dialogs/MediaEditor.vala (+2/-5)
src/Dialogs/PreferencesWindow.vala (+1/-4)
src/Dialogs/RemoveFilesDialog.vala (+2/-7)
src/Dialogs/SmartPlaylistEditor.vala (+2/-2)
lp:~l-admin-3/eidete/dialog-margins
- elementary Apps team: Pending requested
-
Diff: 22 lines (+1/-4)1 file modifiedsrc/Widgets/end_dialog.vala (+1/-4)
lp:~fabiozaramella/pantheon-photos/use-deletable
- Photos Devs: Pending requested
-
Diff: 44 lines (+2/-10)1 file modifiedsrc/Dialogs.vala (+2/-10)
Changed in noise: | |
milestone: | none → freya-rc1 |
Changed in scratch: | |
status: | New → In Progress |
assignee: | nobody → Marcus Wichelmann (l-admin-3) |
description: | updated |
Changed in scratch: | |
status: | In Progress → Fix Committed |
Changed in noise: | |
status: | New → In Progress |
assignee: | nobody → Marcus Wichelmann (l-admin-3) |
Changed in maya: | |
assignee: | nobody → Corentin Noël (tintou) |
Changed in eidete: | |
status: | New → In Progress |
assignee: | nobody → Marcus Wichelmann (l-admin-3) |
Changed in maya: | |
status: | New → Fix Committed |
importance: | Undecided → Low |
milestone: | none → freya-beta2 |
Changed in scratch: | |
milestone: | none → freya-beta2 |
Changed in eidete: | |
status: | In Progress → Fix Committed |
Changed in noise: | |
status: | In Progress → Fix Committed |
milestone: | freya-rc1 → freya-beta2 |
Changed in pantheon-photos: | |
status: | New → In Progress |
assignee: | nobody → Fabio Zaramella (fabiozaramella) |
Changed in pantheon-photos: | |
status: | In Progress → Fix Committed |
Changed in pantheon-photos: | |
milestone: | none → freya-beta2 |
Changed in maya: | |
status: | Fix Committed → Fix Released |
Changed in noise: | |
status: | Fix Committed → Fix Released |
Changed in pantheon-photos: | |
status: | Fix Committed → Fix Released |
Changed in scratch: | |
status: | Fix Committed → Fix Released |
Changed in scratch: | |
milestone: | freya-beta2 → 2.1 |
importance: | Undecided → Low |
To post a comment you must log in.