Remove from Library permanently deletes files [$50]

Bug #1341812 reported by Cassidy James Blaede on 2014-07-14
38
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Photos
Fix Released
Critical
Robert Roth

Bug Description

When you choose "Edit" -> "Remove from Library", Photos permanently deletes the selected photos. This is NOT what the menu item implies and shouldn't happen.

Related branches

Daniel Fore (danrabbit) wrote :

Yeah as far as I can tell it just disappears. No warning and no Undo. From my understanding that menu item should make Photos stop tracking that image, but not actually (re)move the file.

Changed in pantheon-photos:
status: New → Confirmed
milestone: none → freya-beta1
summary: - Remove from Library permanently deletes files
+ Remove from Library permanently deletes files [$20]
Robert Roth (evfool) on 2014-07-16
Changed in pantheon-photos:
assignee: nobody → Robert Roth (evfool)
status: Confirmed → In Progress
Timo Reimerdes (timorei) wrote :

Is this going to be solved via a rename (remove from library => delete image) or via functionality (just stop tracking it)?

I think the right approach would be the renaming, no? After all the "file-metaphor" was mentioned to be becoming obsolete.

Robert Roth (evfool) wrote :

@timorei: based on discussions with Daniel Fore, we have agreed on the following solution: removing from library will send the files to trash, and the trash entry will be the same as trash on the filesystem (but only showing images). I don't know whether the item should be renamed to delete image, maybe Daniel can comment on that.

Timo Reimerdes (timorei) wrote :

Well, if it moves the file to trash, I'd rename it as well - if only for the consistency of action and line AND the consistency between "moving something to the trash" in pantheon-files and pantheon-photos. Imho - if it does the same thing, it should be named the same.

Daniel Fore (danrabbit) on 2014-08-02
summary: - Remove from Library permanently deletes files [$20]
+ Remove from Library permanently deletes files [$50]
Cody Garver (codygarver) on 2014-08-06
tags: added: bounty
RabbitBot (rabbitbot-a) on 2014-08-09
Changed in pantheon-photos:
status: In Progress → Fix Committed
Daniel Fore (danrabbit) on 2014-12-29
Changed in pantheon-photos:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers