Conversation marked unread when trying to underline a selected text using Ctrl+U

[Raashid Ansari]

Loki Beta1
Pantheon Mail 0.10.0

Whenever I write a reply and I want to underline or italicize an already written text using Ctrl+U or Ctrl+I, the whole conversation is marked as unread or read instead of the text being underlined or italicized.

This does not happen for Ctrl+B (bold) since there is no conflict for this keyboard shortcut. However, Ctrl+U and Ctrl+I are supposed to mark a conversation/email as unread and read, respectively. Ctrl+U and Ctrl+I are also shortcuts for underlining and italicizing, respectively, when writing an email.

Perhaps, Pantheon Mail does not recognize that an email is being written when trying to underline/italicize using keyboard shortcuts?

[Ralph Plawetzki (purejava)]

> Perhaps, Pantheon Mail does not recognize that an email is being written when trying to underline/italicize using keyboard shortcuts?

Well, you are somewhat right. The keyboard shortcuts Ctrl+U and Ctrl+I do work for formatting text when you detach the compose email widget (=extra window).

As the keyboard shortcuts mentioned above are defined twice in the application, the appropriate shortcuts need to be initalized depending on whether an email is created or not. This initialization is missing for the inline / not detached compose email widget.

BTW, there are some more keyboard shortcuts defined twice: Ctrl-L (forward email / insert link) and Ctrl-F (forward email / find). The attached MR should fix this issue for all keyboard shortcuts mentioned above.

[Ralph Plawetzki (purejava)]

This is fixed now. We added the missing initialization and changed some of the keyboard shortcuts.
So we are ready for upcoming Gtk 3.20 which has a feature for listing the keyboard shortcuts of an application.

The new keyboard shortcuts are:
* Mark conversation read: (Ctrl + I) -> (Ctrl + Shift + I)
* Mark conversation unread: (Ctrl + U) -> (Ctrl + Shift + U)
* Forward email: (Ctrl + L and F) -> (Ctrl + Shift + F)
* Insert link when composing: (Ctrl + L) -> (Ctrl + K)
* Mark as Strikethrough: (Ctrl + K) -> (Ctrl + %)