| 2016-06-07 17:05:48 |
Danielle Foré |
bug |
|
|
added bug |
| 2016-06-07 17:05:59 |
Danielle Foré |
summary |
Give conversations action properties |
Give conversation's actions properties |
|
| 2016-06-07 17:06:18 |
Danielle Foré |
description |
This is mostly meant to be used to deprecate the use of Gtk.Action
Instead of having setters in geary-controller to control the sensitivity of the reply, forward, archive, etc buttons we should give messages properties like "can_reply" and the property bind the widget sensitivity. This way we can avoid making the widgets public, we only need the conversation's properties to be public and the widgets "subscribe" to that. We can remove a ton of setters from geary-controller and have the sensitivity binding be more obvious by putting it with the widget itself. |
This is mostly meant to be used to deprecate the use of Gtk.Action
Instead of having setters in geary-controller to control the sensitivity of the reply, forward, archive, etc buttons we should give messages properties like "can_reply" and then property bind the widget sensitivity. This way we can avoid making the widgets public, we only need the conversation's properties to be public and the widgets "subscribe" to that. We can remove a ton of setters from geary-controller and have the sensitivity binding be more obvious by putting it with the widget itself. |
|
| 2016-06-07 17:07:15 |
Danielle Foré |
description |
This is mostly meant to be used to deprecate the use of Gtk.Action
Instead of having setters in geary-controller to control the sensitivity of the reply, forward, archive, etc buttons we should give messages properties like "can_reply" and then property bind the widget sensitivity. This way we can avoid making the widgets public, we only need the conversation's properties to be public and the widgets "subscribe" to that. We can remove a ton of setters from geary-controller and have the sensitivity binding be more obvious by putting it with the widget itself. |
This is mostly meant to be used to deprecate the use of Gtk.Action
Instead of having setters in geary-controller to control the sensitivity of the reply, forward, archive, etc buttons we should give messages properties like "can_reply" and then property bind the widget sensitivity. This way we can avoid making the widgets public, we only need the conversation's properties to be public and the widgets "subscribe" to that. We can remove a ton of setters from geary-controller and have the sensitivity binding be more obvious by putting it with the widget itself. We don't need to depend on Gtk.Action to broadcast the action's sensitivity, the code is easier to understand, we save some lines from geary-controller, and everyone wins. |
|
| 2016-06-08 06:53:25 |
Zisu Andrei |
pantheon-mail: status |
New |
Confirmed |
|
