Some account preferences are not visible if the email account is not Gmail, Yahoo or Outlook

[Félix Brezo]

As there is no scrollbar in the account preferences window, when trying to edit them for an account that is not one of the automatically configured ones the number of preferences does not allow the user to check them all (and even see the accept button).

[Ralph Plawetzki (purejava)]

Yes, that is a problem on smaller screens, e.g. some laptops.
I suggested a patch for this upstream [1], that puts the parts of the account configuration dialog into the tabs of a Gtk.Notebook.

Here is how this looks like: http://snag.gy/pCHvK.jpg

The patch is not reviewed so far.

If this would be a solution for elementary os, I could do according adjustments to data/ui/login.glade and provide a patch for pantheon-mail / mail (as it differs slightly from the version upstream).
[1] https://bugzilla.gnome.org/show_bug.cgi?id=714104

[Ralph Plawetzki (purejava)]

Added patch.
The patch introduces a regression that I do not understand. As far as I can see, it happens during initialization and has to do with the shift key event. Could I get some help on this please? :)

(geary:15942): Gtk-CRITICAL **: gtk_activatable_set_related_action: assertion 'GTK_IS_ACTIVATABLE (activatable)' failed
(geary:15942): Gtk-CRITICAL **: gtk_activatable_get_related_action: assertion 'GTK_IS_ACTIVATABLE (activatable)' failed
(geary:15942): Gtk-CRITICAL **: gtk_action_get_tooltip: assertion 'GTK_IS_ACTION (action)' failed
(geary:15942): Gtk-CRITICAL **: gtk_widget_set_tooltip_text: assertion 'GTK_IS_WIDGET (widget)' failed
(geary:15942): Gtk-CRITICAL **: gtk_widget_set_visible: assertion 'GTK_IS_WIDGET (widget)' failed

(gdb) backtrace
#0 0x00007ffff2cd39c3 in g_logv () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#1 0x00007ffff2cd3b32 in g_log () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2 0x00000000004dbb4f in main_toolbar_update_trash_archive_buttons (self=0xf62410, trash=1, archive=1) at /home/rallo/ValaDev/pantheon-mail/src/client/components/main-toolbar.vala:198
#3 0x0000000000489d08 in geary_controller_update_ui (self=0xc77120) at /home/rallo/ValaDev/pantheon-mail/src/client/application/geary-controller.vala:1308
#4 0x000000000048c607 in geary_controller_do_select_folder_co (_data_=0x12ad820) at /home/rallo/ValaDev/pantheon-mail/src/client/application/geary-controller.vala:1425
#5 0x000000000048a78c in geary_controller_do_select_folder_ready (source_object=0xc81820, _res_=0x12a3650, _user_data_=0x12ad820)
    at /home/rallo/ValaDev/pantheon-mail/src/client/application/geary-controller.vala:1370
#6 0x00007ffff3252837 in g_simple_async_result_complete () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#7 0x00007ffff3252899 in ?? () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#8 0x00007ffff2cccab5 in g_main_context_dispatch () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#9 0x00007ffff2ccce18 in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#10 0x00007ffff2cccebc in g_main_context_iteration () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#11 0x00007ffff328444c in g_application_run () from /usr/lib/x86_64-linux-gnu/libgio-2.0.so.0
#12 0x00000000004abff7 in _vala_main (args=0x7fffffffdfa8, args_length1=1) at /home/rallo/ValaDev/pantheon-mail/src/client/application/main.vala:25
#13 0x00000000004ac046 in main (argc=1, argv=0x7fffffffdfa8) at /home/rallo/ValaDev/pantheon-mail/src/client/application/main.vala:7

[Ralph Plawetzki (purejava)]

I analyzed this further.
As the changes to data/ui/login.glade and src/client/accounts/add-edit-page.vala do not result to any gtk-criticals when applied to r < 1891 I took a closer look at r1891.
The first four critical errors above result from Gtk.Button trash_delete being declared a second time as a local variable so that the instance variable private Gtk.Button trash_delete is not used.
The last critical error comes from mail being installed locally and therefore can be ignored.
This branch has a second commit that addresses the crtitical errors.

So the patch to split up the account creation / edit dialog into a Gtk.Notebook should be ready for review :)

The Gtk.Notebook introduces a new label. As I do not know how translations are handled for elementary os it is not contained in the po-Files so far.
Is it the correct way to add the label there?

[zin (zdravko-nikolov)]

I also have this issue, it is frustrating that one can't add a signature to the mail account as a result. Please, fix this in Loki as soon as possible as it hurts business users...

[Danielle Foré (danrabbit)]

I think a simple fix would be just to add a scrolled view to this dialog