Remove spellcheck setting

Bug #1519453 reported by Danielle Foré
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mail
Fix Released
Low
Danielle Foré

Bug Description

Can't think of a good reason why you'd want to disable spell check

Related branches

Sam Hewitt (snwh)
Changed in pantheon-mail:
status: New → Confirmed
Changed in pantheon-mail:
importance: Undecided → Low
Changed in pantheon-mail:
milestone: none → loki-beta1
Changed in pantheon-mail:
status: Confirmed → In Progress
assignee: nobody → Daniel Fore (danrabbit)
Changed in pantheon-mail:
status: In Progress → Fix Committed
milestone: loki-beta1 → loki-alpha1
Revision history for this message
Giulio Sant (giulio-sant) wrote :

Could you explain the reason behind this decision? I don't know which scenario you had in mind, but personally this is a major annoyance because I type stuff in at least two different languages on a regular basis, so whenever I use a language different from the system default, my text gets all underlined by the spellcheck system.

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Giulio I think the reasoning is that all GTK text entries should have spell checking, and disabling that should be at a system level, not in each and every app. Further, I'd say the multilingual use case would be a bug against GTK or the OS; ideally you'd have both languages added so the system knows not to mark valid words in either language as incorrect.

Revision history for this message
Giulio Sant (giulio-sant) wrote :

I totally agree with you. What I don't get, then, is: given that there's a shortcoming either in GTK or in the OS, why remove an option which, at least partly, helps overcoming that shortcoming? I mean, what's the benefit, in this scenario, of taking away the option? To unclutter for uncluttering's sake? Sorry, but I only see an inconvenience for the end user.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hey Giulio, Can you do me a huge favor and file a new issue regarding spell check not being aware of language changes?

I think the immediate benefit is that before we didn't know that there was an i18n issue, and now we do. So now we can work on a solution to a problem that we didn't previously know about :)

Revision history for this message
Giulio Sant (giulio-sant) wrote :

Sure thing I will. Really appreciate your answer. Hope I can spell out the issue correctly ☺

Revision history for this message
Giulio Sant (giulio-sant) wrote :
Cody Garver (codygarver)
Changed in pantheon-mail:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.