make edit-able path bar use gtk.entry [$100]
Bug #996101 reported by
Danielle Foré
This bug affects 10 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Files |
Fix Released
|
Medium
|
KJ Lawrence | ||
elementary Stylesheet |
Fix Released
|
Undecided
|
Danielle Foré |
Bug Description
When the path bar is edit-able it should look like a text entry and not a depressed button.
Related branches
lp:~kjtehprogrammer/pantheon-files/editable-pathbar
- Avi Romanoff (community): Approve
- Jeremy Wootten: Approve
- Danielle Foré: Approve
-
Diff: 2198 lines (+448/-1335)10 files modifiedlibwidgets/BreadcrumbsElements.vala (+2/-1)
libwidgets/BreadcrumbsEntry.vala (+0/-494)
libwidgets/CMakeLists.txt (+1/-3)
libwidgets/LocationBar.vala (+354/-502)
libwidgets/tests/CMakeLists.txt (+0/-27)
libwidgets/tests/tests-pathbar.vala (+0/-213)
src/View/Chrome/TopMenu.vala (+5/-8)
src/View/LocationBar.vala (+75/-81)
src/View/ViewContainer.vala (+4/-5)
src/View/Window.vala (+7/-1)
Changed in pantheon-files: | |
assignee: | nobody → elementary UX Team (elementary-design) |
Changed in pantheon-files: | |
milestone: | luna-beta1 → luna-beta2 |
assignee: | elementary UX Team (elementary-design) → nobody |
Changed in pantheon-files: | |
milestone: | luna-beta2 → luna-beta3 |
Changed in pantheon-files: | |
milestone: | isis-beta1 → none |
Changed in egtk: | |
status: | Fix Committed → Fix Released |
Changed in pantheon-files: | |
status: | Confirmed → Fix Committed |
milestone: | none → isis-beta1 |
Changed in pantheon-files: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Actually, this should happen on the theme side if we want to keep the code in good shape. Marlin already had it like this in the past and I think it was changed because it felt hacky.