put "empty trash" on the bottom right

Bug #897808 reported by Daniel Fore on 2011-11-29
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Files
Confirmed
Wishlist
Unassigned

Bug Description

Instead of having the "empty trash" button on the top of the view, it should be placed in the bottom right-hand corner. This is more consistent with the "call to action" placement used in dialog boxes and makes the button more obvious. Additionally, it avoids moving the icon view when changing between another folder and the Trash.

xapantu (xapantu) on 2011-11-30
Changed in marlin:
status: New → Triaged
importance: Undecided → Low
milestone: none → 0.1
ammonkey (am-monkeyd) wrote :

I am not fan of the idea, all the control buttons are upper. This is not a dialog box.

Changed in marlin:
status: Triaged → Opinion
Daniel Fore (danrabbit) on 2013-01-28
affects: marlin → pantheon-files
Changed in pantheon-files:
milestone: 0.1 → none
status: Opinion → New
Daniel Fore (danrabbit) wrote :

Made a mockup of how this could look.

description: updated
Cody Garver (codygarver) on 2013-02-14
Changed in pantheon-files:
milestone: none → 0.2
status: New → Confirmed
Albert (optimisme) wrote :

Are the mockup background and button colors fine?

Changed in pantheon-files:
assignee: nobody → Albert (optimisme)
Daniel Fore (danrabbit) wrote :

We should probably handle theming in egtk. I would set ".bottom-toolbar" in the code and then I can target something like ".view .bottom-toolbar" in the theme.

Oh and also ".noundo" for the button

Albert (optimisme) wrote :

Sorry, I moved it to the bottom but I don't know how to theme it :(

Also, if it is themed in egtk it wont be available for non elementary distributions using pantheon-files.

I removed myself from assignation.

Changed in pantheon-files:
assignee: Albert (optimisme) → nobody
Jeremy Wootten (jeremywootten) wrote :

At the moment this widget is added using the "add_extra_widget" function of the Slot. This is also used by the network plugin. It is easy to change Slot to add the extra widget to the bottom, but it would also effect the network plugin. If you want to able to put extra widget both at the top and the bottom of the Slot then that function would need an extra parameter (top or bottom).

Daniel Fore (danrabbit) wrote :

Since there's another report about removing "Connect to Server" in the "Entire Network" section (because it's now in the sidebar), I think it's probably fine.

Daniel Fore (danrabbit) wrote :

Just an update about classes. These days we'd probably be packing a "destructive-action" button into a Gtk.ActionBar

Changed in pantheon-files:
milestone: feature-future → loki-beta1
Daniel Fore (danrabbit) wrote :

Another update about classes. This would still be a Gtk.ActionBar, but with "Gtk.STYLE_CLASS_INLINE_TOOLBAR" and a button with "Gtk.STYLE_CLASS_DESTRUCTIVE_ACTION"

Cody Garver (codygarver) on 2016-02-10
Changed in pantheon-files:
importance: Low → Wishlist
Daniel Fore (danrabbit) on 2016-02-14
Changed in pantheon-files:
milestone: loki-beta1 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments