don't reference and expect non-standard icons, ship branded icons instead
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Audience |
New
|
Undecided
|
Unassigned | ||
Calculator |
Invalid
|
Undecided
|
Unassigned | ||
Camera |
New
|
Undecided
|
Unassigned | ||
Files |
Invalid
|
Medium
|
Unassigned | ||
Maya |
New
|
Undecided
|
Unassigned | ||
Photos |
New
|
Undecided
|
Unassigned | ||
Scratch |
Invalid
|
Undecided
|
Unassigned | ||
Screenshot |
Fix Released
|
Medium
|
Danielle Foré | ||
Switchboard |
Invalid
|
Undecided
|
Unassigned | ||
Terminal |
Invalid
|
Undecided
|
Unassigned | ||
Wingpanel |
New
|
Undecided
|
Unassigned |
Bug Description
Most elementary desktop apps don't ship the icons (to /usr/share/
1) Apps not shipping their own icon might show in Application Menus with the "missing icon" icon.
2) The affected apps will not show up in "Application Centers" which are using appdata for metadata, because the metadata is deemed to be invalid due to a non-existent icon (not in the package) being referenced at metadata generation time.
This behavior is intentional, because metadata generation for one package cannot (and should not) depend on other packages being present (to be reproducible).
For example, some elementary apps don't show up in GNOME Software because of that - this affects at least ubuntu and fedora, probably other distros too.
The affected packages are (I may have missed some in that list):
application icon name
-------
audience multimedia-
maya-calendar office-calendar
screenshot-tool accessories-
snap-photobooth accessories-camera
wingpanel wingpanel
Related branches
- elementary Apps team: Pending requested
-
Diff: 5615 lines (+5396/-5)25 files modifieddata/icons/128x128/system-file-manager.svg (+289/-0)
data/icons/16x16/system-file-manager.svg (+163/-0)
data/icons/24x24/system-file-manager.svg (+415/-0)
data/icons/32x32/system-file-manager.svg (+331/-0)
data/icons/48x48/system-file-manager.svg (+285/-0)
data/icons/64x64/system-file-manager.svg (+273/-0)
data/icons/CMakeLists.txt (+6/-0)
data/icons/CMakeLists.txt.~1~ (+6/-0)
data/icons/CMakeLists.txt.~2~ (+2/-0)
libcore/CMakeLists.txt (+42/-1)
libcore/Resources/Icons/24/selection-add.svg (+95/-0)
libcore/Resources/Icons/24/selection-checked.svg (+2738/-0)
libcore/Resources/Icons/24/selection-remove.svg (+162/-0)
libcore/Resources/Icons/process-completed-symbolic.svg (+33/-0)
libcore/Resources/Icons/process-error-symbolic.svg (+33/-0)
libcore/Resources/Icons/selection-add.svg (+76/-0)
libcore/Resources/Icons/selection-checked.svg (+96/-0)
libcore/Resources/Icons/selection-remove.svg (+210/-0)
libcore/Resources/Icons/view-column-symbolic.svg (+78/-0)
libcore/Resources/pantheon-files.gresource.xml (+11/-0)
libcore/marlin-icon-info.c (+44/-0)
libwidgets/Chrome/ViewSwitcher.vala (+1/-1)
src/Application.vala (+1/-2)
src/View/Window.vala (+5/-0)
src/marlin-icon-renderer.c (+1/-1)
- Fabio Zaramella (community): Approve
-
Diff: 1977 lines (+1945/-0)5 files modifieddata/CMakeLists.txt (+4/-0)
data/icons/128/accessories-screenshot.svg (+545/-0)
data/icons/32/accessories-screenshot.svg (+371/-0)
data/icons/48/accessories-screenshot.svg (+462/-0)
data/icons/64/accessories-screenshot.svg (+563/-0)
tags: | added: cross-distro |
tags: | added: fedora |
Changed in pantheon-files: | |
assignee: | nobody → Jeremy Wootten (jeremywootten) |
importance: | Undecided → Medium |
milestone: | none → juno-beta1 |
status: | New → Confirmed |
Changed in pantheon-files: | |
status: | Confirmed → In Progress |
Changed in screenshot-tool: | |
importance: | Undecided → Medium |
milestone: | none → juno-beta1 |
status: | New → Confirmed |
Changed in pantheon-files: | |
assignee: | Jeremy Wootten (jeremywootten) → nobody |
status: | In Progress → Confirmed |
Changed in screenshot-tool: | |
assignee: | nobody → Daniel Fore (danrabbit) |
status: | Confirmed → In Progress |
Changed in screenshot-tool: | |
status: | In Progress → Fix Committed |
Changed in screenshot-tool: | |
status: | Fix Committed → Fix Released |
Changed in scratch: | |
status: | New → Invalid |
Changed in switchboard: | |
status: | New → Invalid |
description: | updated |
summary: |
- the referenced application icon is not shipped with the package + don't reference and expect non-standard icons, ship branded icons + instead |
Several of these are icon names covered by the fd.o icon naming spec. It doesn't make sense to ship these icons as they are mandated to be present in all icon sets. Namely the following:
AppCenter: system- software- install calculator text-editor
Calculator: accessories-
Files: system-file-manager
Scratch: accessories-
Switchboard: preferences-desktop
Terminal: utilities-terminal