State only saves on clean close

[Cassidy James Blaede]

The app's state is only saved when you explicitly/cleanly close it. If it terminates uncleanly (i.e. crashes, the computer dies, etc.), the state is not saved.

Possible solution: periodically save the state, perhaps after certain actions occur (i.e. after navigating to a folder, opening a tab, or toggling a UI state).

[Ash (ash1991)]

The crash might be because of some open tabs so it's better to ask the next time user opens pantheon-files to restore the last session or the session before that.

[Jeremy Wootten (jeremywootten)]

Ideally Files should never crash! But you are right, because saving the tab state is more complex than binding a simple boolean such as "Show Hidden Files", it is only done on exit at the moment.

[Cassidy James Blaede (cassidyjames)]

Calculator test case:
1. Open Calculator
2. Expand sidebar
3. Use xkill to kill the app
4. Re-open, see that the sidebar is not expanded

When closing the window normally, the sidebar saves its state.

[Cassidy James Blaede (cassidyjames)]

Terminal test case:
1. Open Terminal
2. Navigate to a folder and open two extra tabs
3. Use xkill to kill the app
4. Reopen, see that the state was not saved

When closing the window normally, the location and tabs are saved.

[Danielle Foré (danrabbit)]

Cass, can you define more clearly what you mean by state for each instance? Like Jeremy said, some things (like dimensions) are a simple settings bind, but some things (like tabs) are more complicated

[Cassidy James Blaede (cassidyjames)]

For Files and Terminal, I would expect it to remember the tabs that were open (i.e. if I had the Pictures, Downloads, and Documents folders each open in a tab, I'd think the app would re-open with those tabs still there). For Calculator, the sidebar state is the only thing I can think of off the top of my head.