Set minimum Sizes for windows

Bug #1409354 reported by Marek Doležel on 2015-01-10
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
AppCenter
Fix Released
Low
Fernando Alvarenga
Files
Fix Released
Wishlist
Fernando Alvarenga
Terminal
Confirmed
Low
Unassigned

Bug Description

you can resize files window to make it really small. i think there should be minimum allowed size for files window. we should not allow user to be able to do this. see attachment

Related branches

Jeremy Wootten (jeremywootten) wrote :

I am not in favour of restricting user choice unnecessarily, if nothing permanently bad happens.

Changed in pantheon-files:
importance: Undecided → Wishlist
status: New → Opinion
Fabian Thoma (fabianthoma) wrote :

Looks like this has actually gotten worse, so now I can make it so small that I can't even see all of the widgets, same goes for pantheon-terminal, which really should not be the case.
Switchboard in contrast has a sane minimum size, where everything is still visible, see the attached screenshot

Changed in pantheon-files:
status: Opinion → Confirmed
milestone: none → loki-beta1
Fabian Thoma (fabianthoma) wrote :
summary: - files allows user to make window really small
+ Set minimum Sizes for windows
Daniel Fore (danrabbit) wrote :

I have to agree with Fabian. It doesn't make sense to allow the window to get so small that it causes weird glitches like that or that the app isn't even usable

Changed in pantheon-terminal:
status: New → Confirmed
milestone: none → loki-beta1
Jeremy Wootten (jeremywootten) wrote :

Any suggestions as to a what a suitable minimum size would be? What is 'usable' depends on e.g. how long a path name is in the location bar and how many bookmarks you have. I agree there should not be any visual glitches , though. I could not get the current trunk (r1962) to reproduce those in the attached image or become as small, but it was possible to get the full-screen button to overlap the pathbar.

Cody Garver (codygarver) on 2015-11-30
Changed in pantheon-terminal:
importance: Undecided → Low
Cody Garver (codygarver) on 2016-03-14
Changed in pantheon-files:
milestone: loki-beta1 → loki+1-beta1
milestone: loki+1-beta1 → feature-future
Daniel Fore (danrabbit) on 2017-02-15
Changed in appcenter:
status: New → Confirmed
importance: Undecided → Low
Changed in pantheon-files:
status: Confirmed → In Progress
assignee: nobody → Fernando Alvarenga (ferbarcelona10)

I found the following block in Terminal,

            int minimum_width = t.calculate_width (80) / 2;
            int minimum_height = t.calculate_height (24) / 2;
            set_size_request (minimum_width, minimum_height);
            app.minimum_width = minimum_width;
            app.minimum_height = minimum_height;

Does anybody know what the purpose of this is? This is already setting a size request, therefore it is stopping me from solving the issue.

Changed in appcenter:
status: Confirmed → In Progress
assignee: nobody → Fernando Alvarenga (ferbarcelona10)
RabbitBot (rabbitbot-a) on 2017-02-16
Changed in appcenter:
status: In Progress → Fix Committed
Daniel Fore (danrabbit) on 2017-02-16
Changed in appcenter:
milestone: none → juno-beta1
RabbitBot (rabbitbot-a) on 2017-02-16
Changed in pantheon-files:
status: In Progress → Fix Committed
Daniel Fore (danrabbit) on 2017-02-16
Changed in pantheon-files:
milestone: feature-future → juno-beta1
Cody Garver (codygarver) on 2017-02-26
Changed in pantheon-files:
milestone: juno-beta1 → 0.3.2
status: Fix Committed → Fix Released
Cody Garver (codygarver) on 2017-03-16
Changed in appcenter:
milestone: juno-beta1 → 0.1.4
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers