Ctrl + zoom in List view messes up with row heights

[rahul ranjan]

In List view when I press [Ctrl] and [+] to zoom and zoom it a little too much , the height of the rows get messed up.
On a closer inspection, looks like height of rows keeps on reducing in a regular descending order.

Screencast attached.

[Jeremy Wootten (jeremywootten)]

I cannot reproduce this using trunk rev 1687. There are only a fixed number of zoom-levels so it should not be possible to zoom too much. Does this happen only if you zoom fast or also slow? Only when there are a lot of files in the directory or also when a few?

The list view is going to be switched to fixed-height mode soon.

[rahul ranjan (imrahulranjan)]

I 've a branch where I changed the list view to fixed height. There itself I found the issue. Initially I thought it was due to the change I made, but I could reproduce this even without the change.
Well, I'll try out changing the zoom slowly and see whether it still happens or not

[Jeremy Wootten (jeremywootten)]

There seem to be some bugs that only occur on certain architectures - perhaps due to timing issues. I am running a 32-bit machine with Intel CPU. I cannot reproduce some bugs that occur on the amd64 build, for example - which makes it hard for me to investigate them.

[rahul ranjan (imrahulranjan)]

I'm running 32 bit on a dual Core machine.
I tried to investigate further. Looks like this happens when the number of files in the list is very long.
Whenever the zoom action happens, only the thumbnails/icons in the visible area get resized.

 But issue could be realted to the height too , which too gets messed up.

Nevertheless, I tried setting tree.set_fixed_height_mode (true) in overridden create_view() method for both AbstractTreeView.vala and ListView.vala. The row height remained fixed upon launch, But as soon as zoom is changed it gets messed up all again.
I'm very new to Vala and whole elementary code, So couldn't dwell much deeper.

(Note: setting tree.set_fixed_height_mode (true) also requires column.set_sizing (Gtk.TreeViewColumnSizing.FIXED) to be set.)

[Jeremy Wootten (jeremywootten)]

Thanks for looking into it further Rahul. It sounds as if your machine is similar to mine, so I'll try to reproduce with a larger folder - about how many files do you need to get this (and what mimetype(s))?

[Launchpad Janitor (janitor)]

[Expired for Files because there has been no activity for 60 days.]