Giving invalid details in the connect to Windows server dialog gives two error messages

[PerfectCarl]

When I enter invalid info to connect to Windows server dialog, I get an error message that is "Failed to mount Windows share" which is expected/

If I click to "continue" without changing anything, I get another message "Please verify your user details"

Note that the button label is changing. Not sure that this is a good idea

[PerfectCarl (name-is-carl)]

Second error message

[Jeremy Wootten (jeremywootten)]

Could you suggest what the correct behaviour, error message (s) and button label(s) should be? Thanks.

[PerfectCarl (name-is-carl)]

I found the following behavior that can be related to that issue:

when I try to connect to a SAMBA folder that doesn't require a password as guest, the "connect to server" dialog shows me an error asking me for a password. When I try to click the connect button another time (without changing anything or inputting a password) it works

[PerfectCarl (name-is-carl)]

#3

Here is how I see things.

1) don't display two different error message for the same error

2) try to connect to the server before displaying a message (to fix #4).
Of course, the connection must not bock the ui thread

As for the error message, I have no idea.
It depends on what SAMBA gives us as error: are those codes? Or full fledged string that one must have to translate?

And about the button, I would stay with connect.
The button performs the same action, it should have the same label.
Changing it because there is an error ranges from confusing and borders to nagging.