Files

Change color of headerbar when using a root window

Bug #1353974 reported by swizzle
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Files
In Progress
Wishlist
elementary UX
Files juno-beta1

Bug Description

The terminal and pantheon files could use a darker color or a red headerbar when a root window is running.

Related branches

lp:~jeremywootten/pantheon-files/fix-1631982-run-as-admin-warning
Dieter Debast (community): Needs Fixing
Danielle Foré: Pending (ux) requested
Zisu Andrei: Pending requested
Diff: 325 lines (+134/-34)
4 files modified
data/pantheon-files-pkexec.cmake (+1/-1)
src/Application.vala (+47/-12)
src/View/Widgets/TopMenu.vala (+5/-1)
src/View/Window.vala (+81/-20)
Niclas Lockner (niclasl)
Changed in pantheon-terminal:
status: New → Invalid
Changed in elementaryos:
status: New → Invalid
Changed in pantheon-terminal:
status: Invalid → New
Revision history for this message
Julián Unrrein (junrrein) wrote :

Terminal doesn't do root windows anymore. It just opens a new tab as root.

Changed in pantheon-terminal:
status: New → Invalid
Changed in pantheon-files:
assignee: nobody → elementary UX Team (elementary-design)
Danielle Foré (danrabbit)
Changed in pantheon-files:
importance: Undecided → Wishlist
no longer affects: elementaryos
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

To clarify, no UI code runs as root at all.
Which is a good thing from security perspective, but we can't effectively tell which tabs have root and which do not (without having root ourselves, that is). So this is probably not happening for Terminal.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Wait, I lied. We could use some strace trickery to accomplish detecting root child processes in terminal. It would slow process creation down though.

Zisu Andrei (matzipan)
no longer affects: pantheon-terminal
summary: - change color of headerbar when using a root window
+ Change color of headerbar when using a root window
Changed in pantheon-files:
status: New → In Progress
Zisu Andrei (matzipan)
Changed in pantheon-files:
milestone: none → juno-beta1
Zisu Andrei (matzipan)
Changed in pantheon-files:
status: In Progress → Fix Committed
Cody Garver (codygarver)
Changed in pantheon-files:
status: Fix Committed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.