Files

"Show MenuBar" shouldn't exist

Bug #1131387 reported by Mario Guerriero
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Files
Fix Released
Medium
Victor Martinez
Files 0.1.1

Bug Description

There shouldn't be an option in the UI to show/hide MenuBar and Resources. So Toolbar shouldn't have a popup menu and there should not be any keyboard shourtcut to show/hide MenuBar and Resources.

Related branches

lp:~victored/pantheon-files/no-menubar
Danielle Foré: Approve
Diff: 1667 lines (+101/-921)
11 files modified
libwidgets/Animations.vala (+2/-2)
libwidgets/CMakeLists.txt (+1/-0)
schemas/org.pantheon.files.gschema.xml (+0/-32)
src/CMakeLists.txt (+0/-2)
src/View/Chrome/TopMenu.vala (+4/-2)
src/View/ContextView.vala (+0/-481)
src/View/OverlayBar.vala (+13/-13)
src/View/PropertiesWindow.vala (+20/-10)
src/View/ViewContainer.vala (+12/-41)
src/View/Window.vala (+35/-252)
src/pantheon-files-ui.xml (+14/-86)
Mario Guerriero (mefrio-g)
Changed in pantheon-files:
assignee: nobody → Mario Guerriero (mefrio-g)
status: New → Confirmed
importance: Undecided → Medium
milestone: none → luna-beta2
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in pantheon-files:
status: In Progress → Fix Released
Revision history for this message
Cody Garver (codygarver) wrote :

This patch kills the appmenu (gear).

Changed in pantheon-files:
status: Fix Released → New
milestone: luna-beta2 → luna-beta3
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

My fault, sorry! Now it should work.

Changed in pantheon-files:
status: New → In Progress
Revision history for this message
Cody Garver (codygarver) wrote :

I'm still able to enable the menu bar via right clicking near location bar.

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

You didn't install it in order to update the .xml files :P anyway I dropped the right_click detection for AppMenu so it should be definitively solved.

Revision history for this message
CruelAngel (hendricha) wrote :

Question: The current version of pantheon-files in unity exports a classic style menubar. Are there any plans on removing this feature as well?

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Is the "resources" the "places"? If so, I'm actually quite okay with being able to hide the sourcelist/sidebar. The menubar makes no sense though for sure.

Cody Garver (codygarver)
Changed in pantheon-files:
milestone: luna-beta3 → luna-rc1
assignee: Mario Guerriero (mefrio-g) → nobody
Victor Martinez (victored)
summary: - "Show MenuBar" and "Show Resources" shouldn't exist
+ "Show MenuBar" shouldn't exist
Danielle Foré (danrabbit)
Changed in pantheon-files:
status: In Progress → Fix Committed
Julián Unrrein (junrrein)
Changed in pantheon-files:
status: Fix Committed → Fix Released
assignee: nobody → Victor Martinez (victored)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.