Files

Migrate .sidebar to .source-list

Bug #1084159 reported by Danielle Foré on 2012-11-28

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Files	Fix Released	Low	Victor Martinez	Files 0.1.1
Geary	Confirmed	Undecided	Unassigned
Granite	Fix Released	Low	Victor Martinez	Granite luna-beta2
Shotwell	New	Undecided	Unassigned
elementary Stylesheet	Won't Fix	Low	Unassigned

Bug Description

The CSS class styling Granite's SourcesList should be moved from ".sidebar" to ".source-list" in order to reflect the widget's naming in Granite.

See original description

Tags:

Related branches

lp:~victored/pantheon-files/places-sidebar-granite-expanders

Merged into lp:~elementary-apps/pantheon-files/trunk at revision 1172

Cody Garver (community): Approve on 2013-05-13

elementary Apps team: Pending requested 2013-04-21

Danielle Foré (danrabbit) on 2012-11-28

Changed in granite:
importance:	Undecided → Low
tags:	added: bitesize css

Victor Martinez (victored) on 2012-12-05

summary:	- Migrate .sidebar to .sources-list + Migrate .sidebar to .source-list
Changed in granite:
status:	New → In Progress
assignee:	nobody → Cody Garver (codygarver)
milestone:	none → luna-beta2

Victor Martinez (victored) on 2012-12-18

Changed in granite:
status:	In Progress → Fix Committed

Revision history for this message

Danielle Foré (danrabbit) wrote on 2013-01-31:

Added a few apps that aren't using Granite's SourceList and did not automatically inherit the class name change.

I won't deprecate the name from eGTK until these apps are moved over.

description:

updated

Revision history for this message

jmikelf (jmikelf) wrote on 2013-02-13:

Captura de pantalla de 2013-02-13 21:18:54.png Edit (45.9 KiB, image/png)

i don't know if this is the good place to post this, but there is some inconsistency with sidebars (i'm sure you re allready fixing this and i'm bothering)

Revision history for this message

Danielle Foré (danrabbit) wrote on 2013-02-13:

jmikelf, what you're seeing is a result of Geary not using Granite's SourceList widget. You can file a bug against Geary here: http://redmine.yorba.org/projects/geary/issues

Cody Garver (codygarver) on 2013-04-15

Changed in granite:
status:	Fix Committed → Fix Released

Cody Garver (codygarver) on 2013-04-15

Changed in pantheon-files:
status:	New → Confirmed
importance:	Undecided → Wishlist
milestone:	none → 0.2
importance:	Wishlist → Low
milestone:	0.2 → luna-beta3

Jim Nelson (yorba-jim) on 2013-05-06

Changed in geary:
status:	New → Confirmed

Cody Garver (codygarver) on 2013-05-13

Changed in pantheon-files:
status:	Confirmed → Fix Released
milestone:	luna-beta3 → luna-rc1
assignee:	nobody → Victor (victored)
Changed in granite:
assignee:	Cody Garver (codygarver) → Victor (victored)