Pano13: struct Image initialization error

Reported by tksharpless on 2008-02-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Panotools
Medium
Unassigned

Bug Description

The Pano13 source in the hugin SDK has a typo in line 849 of filter.c, in function SetImageDefaults(). It reads
  bzero(im->formatParam, sizeof(im->precomputedValue));
but should be
  bzero(im->precomputedValue, sizeof(im->precomputedValue));

This leaves 4 of the precomputed values uninitialized since formatParam starts 4 words before precomputedValue and overwrites precomputedCount with (another) zero.

Unlikely to cause malfunction.

rew (r-e-wolff) wrote :

Just checked the source, and except for a few lines movement the bug is still there.

tags: added: libpano patch source
Changed in hugin:
importance: Low → Medium
status: New → Confirmed
rew (r-e-wolff) wrote :

yuv, You comitted this to the source repository (with someone elses name as the patch provider). Or did that someone else push my patch to the repository resulting in your attribution?

rew (r-e-wolff) wrote :

If "this is the one" can you move this to "fix comitted"?

Yuv (yuv) wrote :

Hi Rogier,
I don't know what you mean above. I just checked out the libpano source from SVN, noticed that the error was still there, applied your patch and committed. This bug report will have to be moved to Panotools once that bug tracker is online on Launchpad

Changed in hugin:
status: Confirmed → Fix Committed
Yuv (yuv) wrote :

P.S.: SVN1305

Yuv (yuv) on 2011-01-02
affects: hugin → panotools
tmodes (tmodes) on 2014-01-01
Changed in panotools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers