oslo.messaging 2.6.1 breaks ceilometer unit tests

[Chris Dent]

When running the ceilometer units tests with olso.messaging 2.61 some tests will timeout as follows. Downgrading to 2.5.0 fixes the issue (2.6.0 has unrelated problems with ZMQ constants). More details to follow as I have them.

======================================================================
FAIL: ceilometer.tests.unit.publisher.test_messaging_publisher.RpcOnlyPublisherTest.test_published_no_mock
tags: worker-2
----------------------------------------------------------------------
Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "ceilometer/tests/unit/publisher/test_messaging_publisher.py", line 122, in test_published_no_mock
    collector.wait()
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/oslo_messaging/server.py", line 177, in wait
    self._executor.wait()
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/oslo_messaging/_executors/impl_pooledexecutor.py", line 122, in wait
    self._tombstone.wait()
  File "/usr/lib64/python2.7/threading.py", line 624, in wait
    self.__cond.wait(timeout, balancing)
  File "/usr/lib64/python2.7/threading.py", line 340, in wait
    waiter.acquire()
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/eventlet/semaphore.py", line 113, in acquire
    hubs.get_hub().switch()
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/eventlet/hubs/hub.py", line 294, in switch
    return self.greenlet.switch()
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/eventlet/hubs/hub.py", line 346, in run
    self.wait(sleep_time)
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/eventlet/hubs/poll.py", line 82, in wait
    sleep(seconds)
  File "/home/cdent/src/ceilometer/.tox/py27/lib/python2.7/site-packages/fixtures/_fixtures/timeout.py", line 52, in signal_handler
    raise TimeoutException()
fixtures._fixtures.timeout.TimeoutException

[Chris Dent (cdent)]

In ceilo there are three timing-out tests:

ceilometer.tests.unit.alarm.test_rpc.TestRPCAlarmNotifier.test_notify_alarm
ceilometer.tests.unit.alarm.test_rpc.TestRPCAlarmNotifier.test_notify_non_string_reason
ceilometer.tests.unit.publisher.test_messaging_publisher.RpcOnlyPublisherTest.test_published_no_mock

[Chris Dent (cdent)]

Messaging fix: https://review.openstack.org/#/c/234332/

(this corrects the problems in the three ceilo tests above)

[Davanum Srinivas (DIMS) (dims-v)]

https://review.openstack.org/#/c/234372/ is a better change

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234372
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=c68266b36b5d8e94fef2cca23ea459a01e05a0d2
Submitter: Jenkins
Branch: master

commit c68266b36b5d8e94fef2cca23ea459a01e05a0d2
Author: Mehdi Abaakouk <email address hidden>
Date: Tue Oct 13 18:30:50 2015 +0200

    Use a condition (and/or a dummy one) instead of a lock

    Instead of having to spin in the wait method, just use
    a condition and block until stopping has actually happened,
    when stop happens, it will use the notify_all method to let
    any blockers release.

    Closes-Bug: #1505730

    Change-Id: I3cfbe1bf02d451e379b1dcc23dacb0139c03be76

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235049
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=bbcfcbb1af01c64b6f61ce3d15c5303dd6be26aa
Submitter: Jenkins
Branch: master

commit bbcfcbb1af01c64b6f61ce3d15c5303dd6be26aa
Author: liusheng <email address hidden>
Date: Thu Oct 15 09:20:00 2015 +0800

    Block oslo.messaging 2.6.1 release

    The oslo.messaging-2.6.1 has broken Ceilometer Jenkins job two days, The
    change[1] could hopefully fix the issue, but it is better to block the
    oslo.messaging-2.6.1 to make Ceilometer Jenkins alive now.

    [1] https://review.openstack.org/#/c/234372/

    Related-Bug: #1505730
    Change-Id: Ibb2a8c18651c601c844c3bc9d89f18ae032accf8
    Depends-On: Id1e58a9db0d277de2f30de54db97040811f40ff2

[gordon chung (chungg)]

https://review.openstack.org/#/c/235049/